* [RFC PATCH] configs: drop SBSA_REF from minimal specification
@ 2025-10-23 16:39 Alex Bennée
2025-10-24 7:00 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Alex Bennée @ 2025-10-23 16:39 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Philippe Mathieu-Daudé, Thomas Huth
The whole point of SBSA_REF is for testing firmware which by
definition requires TCG. This means the configuration of:
--disable-tcg --with-devices-aarch64=minimal
makes no sense (and indeed is broken for the
ubuntu-24.04-aarch64-notcg) test. Drop it from minimal and remove the
allow_failure from the test case.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
configs/devices/aarch64-softmmu/minimal.mak | 1 -
.gitlab-ci.d/custom-runners/ubuntu-24.04-aarch64.yml | 2 --
2 files changed, 3 deletions(-)
diff --git a/configs/devices/aarch64-softmmu/minimal.mak b/configs/devices/aarch64-softmmu/minimal.mak
index 0ebc1dca561..3c8582e12cc 100644
--- a/configs/devices/aarch64-softmmu/minimal.mak
+++ b/configs/devices/aarch64-softmmu/minimal.mak
@@ -6,4 +6,3 @@
#
CONFIG_ARM_VIRT=y
-CONFIG_SBSA_REF=y
diff --git a/.gitlab-ci.d/custom-runners/ubuntu-24.04-aarch64.yml b/.gitlab-ci.d/custom-runners/ubuntu-24.04-aarch64.yml
index 46db9ae0138..ee13587d99e 100644
--- a/.gitlab-ci.d/custom-runners/ubuntu-24.04-aarch64.yml
+++ b/.gitlab-ci.d/custom-runners/ubuntu-24.04-aarch64.yml
@@ -107,7 +107,5 @@ ubuntu-24.04-aarch64-notcg:
rules:
- if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
when: manual
- allow_failure: true
- if: "$AARCH64_RUNNER_AVAILABLE"
when: manual
- allow_failure: true
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [RFC PATCH] configs: drop SBSA_REF from minimal specification
2025-10-23 16:39 [RFC PATCH] configs: drop SBSA_REF from minimal specification Alex Bennée
@ 2025-10-24 7:00 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-10-24 7:00 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Thomas Huth
On 23/10/25 18:39, Alex Bennée wrote:
> The whole point of SBSA_REF is for testing firmware which by
> definition requires TCG. This means the configuration of:
>
> --disable-tcg --with-devices-aarch64=minimal
>
> makes no sense (and indeed is broken for the
> ubuntu-24.04-aarch64-notcg) test. Drop it from minimal and remove the
> allow_failure from the test case.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> configs/devices/aarch64-softmmu/minimal.mak | 1 -
> .gitlab-ci.d/custom-runners/ubuntu-24.04-aarch64.yml | 2 --
> 2 files changed, 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-24 7:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-23 16:39 [RFC PATCH] configs: drop SBSA_REF from minimal specification Alex Bennée
2025-10-24 7:00 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).