From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C01C433E7 for ; Tue, 1 Sep 2020 07:04:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A86F12151B for ; Tue, 1 Sep 2020 07:04:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A86F12151B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD0Kn-0003h5-TT for qemu-devel@archiver.kernel.org; Tue, 01 Sep 2020 03:04:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD0Jv-0002h0-6L; Tue, 01 Sep 2020 03:03:07 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:49003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD0Jt-0005tN-Dy; Tue, 01 Sep 2020 03:03:06 -0400 Received: from [192.168.100.1] ([82.252.135.186]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MvsR7-1kTZlU2TMF-00suGO; Tue, 01 Sep 2020 09:02:59 +0200 Subject: Re: [PATCH-for-5.1 v2] hw/isa/isa-superio: Fix IDE controller realization To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200721124516.9602-1-f4bug@amsat.org> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: <3d71c7f7-a66e-3db6-4389-77c27f9cd8f9@vivier.eu> Date: Tue, 1 Sep 2020 09:02:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200721124516.9602-1-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:xVe8z7cPlqslH11V9yhJQ69j8Z2NpwFsMS6wzi3t/92lE94wZqJ 3bJtQAQGEZymsp9slwPPLFS9qki7GFXBO4vl989LeyO8ZVfz0eChcz69NdmgwUjfLVfGTfM /XJW/l04TcwQtll6b+yCCcEb2MwqndrrhhIUTWDELf5b3DmTdxmyxXgfs/l8+eivY5KXMsD Vm3gc+ZjAAjERWQHgSDBg== X-UI-Out-Filterresults: notjunk:1;V03:K0:Q4iKYGb8gYE=:T4OIkfR1omeTprm8XzuYyM Y9r8BjicBVnRgFAPDwo0IE4gV+6PP0YrecWVehZlEsbqbZWpbyu5rFSBkWbiaAMRhe6r79YEF YnAab0SgW/IY0VqPu1LEiiMedx+4YjPiWxI1MOFuGcgx+nB6gvoXQMN6jCCMebjfcm/wjXTcD VpCHgoz0EmGLV6owlH5cWjyUKfL0otSBotyFQPLYY1/a0kK4BOHYeGfYn2NfivJNtgJ0fcc+Q RaWLit/O49+GGMw2e/+bpd77X/BUuDTlt/uLlT9dYuj5HWdC39aRGcBc4P9IURpV8cXt2CfgO fGdwrtCgRD8LLSpGIwMfLtaG4HMpFgeUsq4eqQG262UYq04MvBhnwiL2ASq/1Rx1YgXmRAU2B CjlXkE1ZDx/KHCVRaVoS8qz7PYTK7unncZ3PrnXbWPlKfLEzYbV7OIO19FApWM+C1G0vQTUo8 /1iLiGgMgbHHcGYxiGl+rjDzjesDdWKsFYXyJrwrOnaImlBDaZfqKH3O5DJtafnrx3saZRCIg +tz8KnW/Ro90IvM6I/k2WtYVhdQNxdwiafvPBMEAU7tRq3ptjxPbJ6vdvXZA2tWXl9d6OykaU ygH6rJDBjSq6CUn7RlLiwbgFRPi5UxSpv0irfotcPCHhndgZxd9ybK95X8aCODi4oFBNcq8dw yxZn6KlBlNGBMDwuB5vqNT6JIlkDdUr/ZAbjy51lT329nOu2CuxMFBB8vWHKRQ0gnHSHHyLv3 VtGLsrxh6lOuqIloLSBpIqyBroSDr+lfXfr/QymiRh53c1DVP2zGZ+NmTYpvxPrb8SAqfbSXu +AQV9fcVypvhk8zl1CPiFAXsXV6IJhMCPspqM7YKcPaj4G51Q4E1RA+qhRklXzYjbGICCGi Received-SPF: none client-ip=217.72.192.74; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 03:03:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-2.13, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Paolo Bonzini , Markus Armbruster , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 21/07/2020 à 14:45, Philippe Mathieu-Daudé a écrit : > When realizing a Super I/O with IDE controller [*], we get: > > qom/object.c:1684: object_property_try_add_child: Assertion `!child->parent' failed. > Aborted (core dumped) > > This is because the device is already realized when we try to > add the QOM property to the parent. Fix by realizing *after* > adding the QOM relationship. > > [*] Set ISASuperIOClass::ide.count = N with N not zero > (no such thing currently exists; the bug is latent) > > Fixes: e508430619 ("hw/isa/superio: Make the components QOM children") > Reviewed-by: Markus Armbruster > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Reword bug is latent (Markus) > --- > hw/isa/isa-superio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/isa/isa-superio.c b/hw/isa/isa-superio.c > index e2e47d8fd9..179c185695 100644 > --- a/hw/isa/isa-superio.c > +++ b/hw/isa/isa-superio.c > @@ -158,8 +158,8 @@ static void isa_superio_realize(DeviceState *dev, Error **errp) > if (k->ide.get_irq) { > qdev_prop_set_uint32(d, "irq", k->ide.get_irq(sio, 0)); > } > - isa_realize_and_unref(isa, bus, &error_fatal); > object_property_add_child(OBJECT(sio), "isa-ide", OBJECT(isa)); > + isa_realize_and_unref(isa, bus, &error_fatal); > sio->ide = isa; > trace_superio_create_ide(0, > k->ide.get_iobase ? > Applied to my trivial-patches branch. Thanks, Laurent