From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bv5LM-0007aG-4t for qemu-devel@nongnu.org; Fri, 14 Oct 2016 12:28:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bv5LH-0001cl-14 for qemu-devel@nongnu.org; Fri, 14 Oct 2016 12:28:22 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:53881 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bv5LG-0001ca-Rt for qemu-devel@nongnu.org; Fri, 14 Oct 2016 12:28:18 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9EGNmLp020318 for ; Fri, 14 Oct 2016 12:28:17 -0400 Received: from e06smtp08.uk.ibm.com (e06smtp08.uk.ibm.com [195.75.94.104]) by mx0b-001b2d01.pphosted.com with ESMTP id 26315tvpyn-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 14 Oct 2016 12:28:17 -0400 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 14 Oct 2016 17:28:15 +0100 References: <20161011141235.95730-1-pasic@linux.vnet.ibm.com> <20161014155919.GI3482@stefanha-x1.localdomain> From: Halil Pasic Date: Fri, 14 Oct 2016 18:27:59 +0200 MIME-Version: 1.0 In-Reply-To: <20161014155919.GI3482@stefanha-x1.localdomain> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fJQG0D59OOXdc2Uu0tR1wvpjS4PC2aX6H" Message-Id: <3d9f0297-47a4-d782-ecba-70542ce8548e@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v5 1/1] block: improve error handling in raw_open List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-block@nongnu.org, Kevin Wolf , Cornelia Huck , qemu-devel@nongnu.org, Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fJQG0D59OOXdc2Uu0tR1wvpjS4PC2aX6H From: Halil Pasic To: Stefan Hajnoczi Cc: qemu-block@nongnu.org, Kevin Wolf , Cornelia Huck , qemu-devel@nongnu.org, Max Reitz Message-ID: <3d9f0297-47a4-d782-ecba-70542ce8548e@linux.vnet.ibm.com> Subject: Re: [Qemu-block] [PATCH v5 1/1] block: improve error handling in raw_open References: <20161011141235.95730-1-pasic@linux.vnet.ibm.com> <20161014155919.GI3482@stefanha-x1.localdomain> In-Reply-To: <20161014155919.GI3482@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/14/2016 05:59 PM, Stefan Hajnoczi wrote: > On Tue, Oct 11, 2016 at 04:12:35PM +0200, Halil Pasic wrote: >> > Make raw_open for POSIX more consistent in handling errors by settin= g >> > the error object also when qemu_open fails. The error object was set= >> > generally set in case of errors, but I guess this case was overlooke= d. >> > Do the same for win32. >> >=20 >> > Signed-off-by: Halil Pasic >> > Reviewed-by: Sascha Silbe >> > Tested-by: Marc Hartmayer (POSIX only)= >> >=20 >> > --- >> >=20 >> > Stumbled upon this (POSIX) while testing VMs with too many SCSI disk= s in >> > respect to my nofile limit. When open hits the nofile limit while tr= ying >> > to hotplug yet another SCSI disk via libvirt we end up with no adequ= ate >> > error message (one stating too many files). Sadly this patch in not >> > sufficient to fix this problem because drive_new (/qemu/blockdev.c) >> > handles errors using error_report_err which is documented as not to = be >> > used in QMP context. >> >=20 >> > The win32 part was not tested, and the sole reason I touched it is >> > to not introduce unnecessary divergence. >> >=20 >> > v4 -> v5: >> > * fix qemu-iotests by adding the filename to the message > This patch doesn't modify any iotests golden master files. Does this > mean the iotests output is unchanged? >=20 Exactly. Instead of modifying the golden masters I choose to modify the message generated by me and make it more verbose by appending the filename in question. Thanks for the review! Halil --fJQG0D59OOXdc2Uu0tR1wvpjS4PC2aX6H Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAEBAgAGBQJYAQebAAoJEA0vhuyXGx0APr4QAILImGF+7TltOEtjxd47ddEF ETPZybNgoGLPNGPt5usDkB0RH5taK4gprec+PuklJMvUbvxDtnxW2S2nV8AEfb6g FCeH3tNNoPP26esG1xf2QIZYgZwSVp0sG0lfHJGFqyopYKj07mT6sSVsATMV3dKv 9X2DDnTEBxD8tUtPjxgNtzDH3vByK6bBdyJeZ2xBYm+TiwyI0TcwJctjFD4ki5MW plmzmwZ665FILJA51IQJbbtYZfLBf64rRzR5b5f/GyIz7n8BjEieLKodUXt0HstZ k64UU22ekgornbSkqCYq+lnnltuct1v7PKEpOTHx+XYAF+OTIyHHa1mflPh30v2x 2RILXrKNkJIQ8TvSNUhzOyKgNmcWnqHOUCoIph26J3wzmPANmC+L/uyz0SkYxlT2 yfVZcdSf6Ebm+N93Z/DBxOtO0JCRNluRlGOXm7oyZMQR7e/C3tHUCyOW5ma/ENhu YRfs5zeZVNptxLgwK4E8Hhws5nErE51BERfJTZMGJtR2hvG20VF2lL5HcblBH4dE dfn6NlKccNWrlB12PbG/mv38CyI9g5YbgbjospQUDmmT4ZQdh3fdTFBQPPXfbCPj cbkFkZjYTcvzOGuc59IXHRKUd7M0SpTew/eehGk8TqXrj7rOrQFOlCI+nb9FjVaU Z65Hcpg4u021B/UgL/MV =SlFQ -----END PGP SIGNATURE----- --fJQG0D59OOXdc2Uu0tR1wvpjS4PC2aX6H--