qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Fam Zheng <famz@redhat.com>,
	qemu-devel@nongnu.org,
	Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: "Eric Blake" <eblake@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Jan Kiszka" <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH for-2.13 v3 0/2] slirp: Add query-usernet QMP command
Date: Tue, 20 Mar 2018 10:37:33 +0800	[thread overview]
Message-ID: <3da0908b-5ccf-b233-f0b3-efc9df39a9c2@redhat.com> (raw)
In-Reply-To: <20180316062822.15425-1-famz@redhat.com>



On 2018年03月16日 14:28, Fam Zheng wrote:
> v3: - Add Eric's rev-by to patch 2.
>      - Address Eric's comments on patch 1:
>        * Fix spell/grammar: "programmed", "awaiting".
>        * Fix include "qapi/qapi-commands-net.h".
>        * Underscores to dashes.
>        * "Since 2.13" now.
>
> v2: Fix compiler error. [patchew]
>
> The command is a counterpart of HMP "info usernet" and is at least very useful
> for the VM tests. So add it.
>
> Fam Zheng (2):
>    slirp: Add "query-usernet" QMP command
>    tests: Use query-usernet instead of 'info usernet'
>
>   net/slirp.c        |  26 +++++++
>   qapi/net.json      | 201 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>   slirp/libslirp.h   |   2 +
>   slirp/misc.c       | 156 +++++++++++++++++++++++++++++------------
>   slirp/tcp.h        |  15 ----
>   tests/vm/basevm.py |  14 ++--
>   6 files changed, 347 insertions(+), 67 deletions(-)
>

Hi Samuel:

Does this looks good for you? I believe it's better to be merged through 
your tree.

Thanks

      parent reply	other threads:[~2018-03-20  2:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16  6:28 [Qemu-devel] [PATCH for-2.13 v3 0/2] slirp: Add query-usernet QMP command Fam Zheng
2018-03-16  6:28 ` [Qemu-devel] [PATCH for-2.13 v3 1/2] slirp: Add "query-usernet" " Fam Zheng
2018-05-01 20:41   ` Samuel Thibault
2018-05-02  7:29     ` Fam Zheng
2018-05-02  7:44       ` Thomas Huth
2018-05-02  9:11         ` Fam Zheng
2018-05-02  7:45       ` Samuel Thibault
2018-05-02  8:20         ` Thomas Huth
2018-03-16  6:28 ` [Qemu-devel] [PATCH for-2.13 v3 2/2] tests: Use query-usernet instead of 'info usernet' Fam Zheng
2018-03-20  2:37 ` Jason Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3da0908b-5ccf-b233-f0b3-efc9df39a9c2@redhat.com \
    --to=jasowang@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).