From: Laszlo Ersek <lersek@redhat.com>
To: Thorsten Kohfeldt <thorsten.kohfeldt@gmx.de>,
Paolo Bonzini <pbonzini@redhat.com>,
armbru@redhat.com, lcapitulino@redhat.com,
alex.williamson@redhat.com, peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hmp: Improve 'info mtree' with optional parm for mapinfo
Date: Tue, 20 Sep 2016 20:46:03 +0200 [thread overview]
Message-ID: <3dacf881-3c1d-ab04-b0f2-3c8ecb6095e9@redhat.com> (raw)
In-Reply-To: <0700c05a-d9a4-4bd8-874e-4aeefd85304e@gmx.de>
On 09/20/16 20:23, Thorsten Kohfeldt wrote:
>
> Am 20.09.2016 um 02:51 schrieb Laszlo Ersek:
>> I think it would make sense to work from the pre-rendered FlatView,
>> if the information you can get out of it covers your needs.
>
> I assume you know by now that I do _not_ feel that it covers my needs.
Okay. I guess you've made your point convincingly enough (although I'm
just an interested bystander in this thread). I think the patch has a
very low chance for regressions and it shouldn't draw in a big
maintenance burden, so it could be considered "pure improvement" as-is.
I'm not volunteering to do a full review. One thing I notice though is
that the constification of memory_region_size()'s sole parameter could
be / should be moved into a separate, "prep" patch.
(I propose you wait for further feedback before reposting just with this
change.)
Thanks
Laszlo
next prev parent reply other threads:[~2016-09-20 18:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 0:48 [Qemu-devel] [PATCH] hmp: Improve 'info mtree' with optional parm for mapinfo Thorsten Kohfeldt
2016-09-15 9:52 ` Paolo Bonzini
2016-09-16 17:06 ` Laszlo Ersek
2016-09-20 0:16 ` Thorsten Kohfeldt
2016-09-20 0:51 ` Laszlo Ersek
2016-09-20 7:56 ` Paolo Bonzini
2016-09-20 18:29 ` Thorsten Kohfeldt
2016-09-21 15:06 ` Paolo Bonzini
2016-09-20 18:23 ` Thorsten Kohfeldt
2016-09-20 18:46 ` Laszlo Ersek [this message]
2016-09-20 20:18 ` Thorsten Kohfeldt
2016-09-22 19:43 ` [Qemu-devel] [PATCH v2] vfio: Add support for mmapping sub-page MMIO BARs Thorsten Kohfeldt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dacf881-3c1d-ab04-b0f2-3c8ecb6095e9@redhat.com \
--to=lersek@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thorsten.kohfeldt@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).