From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34DDAC87FCB for ; Mon, 4 Aug 2025 22:56:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uj45u-0002yY-Eb; Mon, 04 Aug 2025 18:55:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uj45r-0002wc-5w for qemu-devel@nongnu.org; Mon, 04 Aug 2025 18:55:47 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uj45d-00005w-Oa for qemu-devel@nongnu.org; Mon, 04 Aug 2025 18:55:36 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-76bd202ef81so5370840b3a.3 for ; Mon, 04 Aug 2025 15:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754348132; x=1754952932; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1gRXBSmLKGaLNVF2FdE2ZTYiCMmsp/V3kiOQiKyG3Io=; b=Aa+1QTE+W0N/hZRjhIhss+AAS2IOYjyZABVtYAUPG6Oh4ablkOtweuCT58yzNU/IBk r+ZefjZzIiZmcqW49fDBZbUvL2Awjgj7qsLJH8ggSq0AxYgptQa0MRz6sbGiSzxYhXTa dp6JKCiehSa0TFcG5Yj6Ac2CCAWnT0jGIeehSXn6/iLgIMFhPk/HX48wXYznx74odIH2 5LftUiJ3b6cV8ITPG6eHOnP6d4FIzRDGJmNvJ1t0soh44tCG4j3rwBAeS31j+riGM5Pa Cfu76Sxq6sid6CKotEK4UQf0ONIM40q7nyJl3MT5BOiOvFWrM5WsXDL3kgdqS5vTR22c Ajww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754348132; x=1754952932; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1gRXBSmLKGaLNVF2FdE2ZTYiCMmsp/V3kiOQiKyG3Io=; b=Rjtn/U3VpkJToQc0xi6/FwIXalhdKn2U97oKdHef+H8UmD1gMZvJ7csktX+aimHU5z kzyeiERrdgTRwVf4OjbRA+99PC16i7rcNHJO3DnD3DMIr8X0Ppm5WLyqnuZs3ZO8IVzE IKDLx9bnUCwuMsac9CQEUhIGOq1CmF3nuMyt+ioJj/RnT3Wd1FhaNJrO8CaWDLIbIr4r 3ksWU+ZBNX84yx78DMlwaIqRnmoJyTqhezVSo2JuyQaCLTp1z4IOJsW9rIhjse5q8YPz muSpjCJkQqoAMxVDGOekz04EQXVk5Kzmh+IFgAK6fbgmYfii+L6mpGuJV9QQkE2eH0+K jM1Q== X-Forwarded-Encrypted: i=1; AJvYcCWx0RF/hXcgw7kGC+PPpXikVVEsXrC8QPCiCPxRRXeut0sdy1SJApAY/n2KQfMy24UoVBA/1Sh79WYk@nongnu.org X-Gm-Message-State: AOJu0Yx/2Uk/R2D3+oVoVDi6Sc7TMjRetF3DOJfv8ag7M3jbqEtEFkvr jHqco5sk6lZTxJeeGSDKnQxenE4LKQ7wR9ldcLKJF0soOyp+ulyQQsbwuAmuV7pwjUA= X-Gm-Gg: ASbGncv/qnPjQj33eskH6spD3aD0YIPzOHttyKw2h0MwfBudme/0TF/qaTPsR/6GToi nL2Pdkmf2HdyNuGrnWJTJV+paXv4ZQUlmnUuB4Red+VjejEv6g9d4QiwtSTqpUNAkJocq0tIliR eQHlhJq2X1SyBof326XfdIVjNK01WJnGVMcYhBiAhkWvZb1WdNJAEjCMJjaaOZWSJbETwMoqt5W LVKwYRY947eThY8DNAX8pm80ICMLiPx+uIJosCx/rS5AaoJbejdyNStHFa9gwJzrRLutUwPzAm7 WOwyAZYPD151yD2AHGxOOnAp7gmQuxwBpke1cXuo2vaaIyaIFcp7kgR8VilSJzj8fUCnZjjj3wG MI0nX+HhOvBs9XrgLtX+kOZqLGoBv8U3MwIAaBOdu X-Google-Smtp-Source: AGHT+IESCQBHKNoHTUnzaSGR6MwUqHVi9IYXSqqW9hiqFK+MEiyCA3HV/KV8UpoIzWnHMUsxUKjr1Q== X-Received: by 2002:a05:6a00:1a14:b0:76b:d791:42e5 with SMTP id d2e1a72fcca58-76bec4bf168mr11445432b3a.17.1754348132013; Mon, 04 Aug 2025 15:55:32 -0700 (PDT) Received: from [192.168.4.112] ([180.233.125.160]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bea205365sm7109511b3a.83.2025.08.04.15.55.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Aug 2025 15:55:31 -0700 (PDT) Message-ID: <3db084fb-0646-4dc0-91a1-a7dba275d18d@linaro.org> Date: Tue, 5 Aug 2025 08:55:24 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-for-10.1 v2 02/11] hw/sd/sdcard: Factor sd_response_size() out To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Peter Maydell , qemu-devel@nongnu.org Cc: Ben Dooks , qemu-riscv@nongnu.org, qemu-block@nongnu.org, qemu-arm@nongnu.org, Guenter Roeck , Bin Meng References: <20250804133406.17456-1-philmd@linaro.org> <20250804133406.17456-3-philmd@linaro.org> From: Richard Henderson Content-Language: en-US In-Reply-To: <20250804133406.17456-3-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x430.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/4/25 23:33, Philippe Mathieu-Daudé wrote: > Set @rsplen once before switching to fill the response buffer. > This will allow to assert in a single place that the buffer is > big enough to be filled with the response. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 36 +++++++++++++++++++++++++++++------- > 1 file changed, 29 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson r~