From: Paolo Bonzini <pbonzini@redhat.com>
To: Vincent Palatin <vpalatin@chromium.org>,
qemu-devel <qemu-devel@nongnu.org>
Cc: Yu Ning <yu.ning@linux.intel.com>, Stefan Weil <sw@weilnetz.de>,
"Michael S . Tsirkin" <mst@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 4/4] hax: add Darwin support
Date: Thu, 22 Dec 2016 10:49:30 +0100 [thread overview]
Message-ID: <3de5e377-b08e-d286-219f-36e4208bdfdc@redhat.com> (raw)
In-Reply-To: <bc2fa770d55e472477bcd5fef1524a2c5314d7f0.1482164622.git.vpalatin@chromium.org>
On 19/12/2016 17:24, Vincent Palatin wrote:
> diff --git a/cpus.c b/cpus.c
> index 0e01791..b8db313 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1264,6 +1264,11 @@ static void qemu_cpu_kick_thread(CPUState *cpu)
> return;
> }
> cpu->thread_kicked = true;
> +#ifdef CONFIG_DARWIN
> + if (hax_enabled()) {
> + cpu->exit_request = 1;
> + }
> +#endif
> err = pthread_kill(cpu->thread->thread, SIG_IPI);
> if (err) {
> fprintf(stderr, "qemu:%s: %s", __func__, strerror(err));
Instead of this, please place the "if" in qemu_cpu_kick before the call
to qemu_cpu_kick_thread. This way, it will be common to Win32 and Darwin.
Thanks,
Paolo
next prev parent reply other threads:[~2016-12-22 9:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 16:24 [Qemu-devel] [PATCH v5 0/4] Add HAX support Vincent Palatin
2016-12-19 16:24 ` [Qemu-devel] [PATCH v5 1/4] kvm: move cpu synchronization code Vincent Palatin
2016-12-19 16:24 ` [Qemu-devel] [PATCH v5 2/4] target-i386: Add Intel HAX files Vincent Palatin
2016-12-19 16:24 ` [Qemu-devel] [PATCH v5 3/4] Plumb the HAXM-based hardware acceleration support Vincent Palatin
2016-12-22 9:57 ` Paolo Bonzini
2017-01-05 13:50 ` Vincent Palatin
2017-01-05 14:01 ` Paolo Bonzini
2017-01-05 21:38 ` Paolo Bonzini
2017-01-06 14:08 ` Vincent Palatin
2017-01-09 13:03 ` Paolo Bonzini
2017-01-09 16:54 ` Vincent Palatin
2017-01-09 6:17 ` Yu Ning
2016-12-19 16:24 ` [Qemu-devel] [PATCH v5 4/4] hax: add Darwin support Vincent Palatin
2016-12-22 9:49 ` Paolo Bonzini [this message]
2017-01-05 13:50 ` Vincent Palatin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3de5e377-b08e-d286-219f-36e4208bdfdc@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=vpalatin@chromium.org \
--cc=yu.ning@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).