From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A57C8D6A221 for ; Thu, 14 Nov 2024 18:59:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBf3y-0001ZP-FV; Thu, 14 Nov 2024 13:59:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBf3u-0001P4-U3 for qemu-devel@nongnu.org; Thu, 14 Nov 2024 13:59:27 -0500 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tBf3r-0000t7-Tm for qemu-devel@nongnu.org; Thu, 14 Nov 2024 13:59:26 -0500 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-7eab7622b61so739827a12.1 for ; Thu, 14 Nov 2024 10:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731610762; x=1732215562; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=URIf27BMDWz/zZ/r2hCSZpn4yj54Db/MC3Z3NDMOMzo=; b=gafzol5jCLNuh5VsAHGKUxfBMpBRFC1DoPVOARv+Gk3h5PGCx9gd99aEGnemPnuUTt XcW+AQEiYy64tBV7It0/WUHVWpY4+tdmvqEup97h2qtCuFDUcfhzNDMBuLRWTaD7voBJ zZDzraVYLy0YG1r0CWGdZNnoFK9SF5I27L5GmLqhaRiH8iiFXhVUz6we4Vtbn/4EifXQ ccqYh31pHo5/jHu4j9BvSgaMtW3YYxwix9Hoeqqycr09ZEk1iOWbYhfWZygqGdlduzsu qu28AZbKijz75nRZlEmXcy716lgr5T5/DK/fRSvrsP7J8Jvt3a5GIX+ZTZ+kr54Udy2S Vx3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731610762; x=1732215562; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=URIf27BMDWz/zZ/r2hCSZpn4yj54Db/MC3Z3NDMOMzo=; b=S4DuxWPbAeDEow8zSp9ZLznqoL/vnXXshVc+Oh8Kweg4kwayGvJtNGpHapp7gN/HK9 C+LxaILrqaFnPZ2fyz+ch0Q1pMvYCKArR19Tc6wvJkITXgGAirOWQ0w6JfYkXOCofevd WuAqHg6iyrhJzdKqhElBcxmJpU47D5JGiAuwXfW9lCWc9Rtnw284QuD4eFVWDD/qgeVh N+wDGcaHPUnUb0gPHJyKCMWO4Aq6aGM5rMEoUZxIxIpKMUsUA6mW8X4/i3RnmPEMdpWr RtTqtvMGmIhj6hx4A0xOFKPapDZLq0IWxuR1xzWpPCdUSg5cRbGJ1z5eUdrmVGOF3TmY yMdg== X-Forwarded-Encrypted: i=1; AJvYcCVjCTu0ylUz7oP79qfd+pq2MshvJcE/QgT1ibhKJc7wL1zMguMAy+IOU/tjVL6LJzr3FZyjOsgVBeU+@nongnu.org X-Gm-Message-State: AOJu0YwcThKHeDe0WB1ig7unmMtY5KmrprUwdq/izq669SpHsLaPuALW 0Dr0zkUxGqBuxAEl4lcpceqsFk81HG00jKyUcX7UISkORzz0uBou0iNniYIFtUsDglWHeDJY7Wn 5 X-Google-Smtp-Source: AGHT+IGw4aiMg4SBCO50N4PjhLOiaZtixPRJtiTqAdcZnNeXjDwiLkCbsQ6JXSp4cgZfdwGsfMO1Cg== X-Received: by 2002:a05:6a20:8421:b0:1d9:c6e8:60fc with SMTP id adf61e73a8af0-1dc228931b2mr36495412637.6.1731610762399; Thu, 14 Nov 2024 10:59:22 -0800 (PST) Received: from [192.168.0.4] ([71.212.136.242]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7f8b37f8640sm1423538a12.49.2024.11.14.10.59.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2024 10:59:22 -0800 (PST) Message-ID: <3de882ce-a6cf-476b-94e4-210b2dd6173c@linaro.org> Date: Thu, 14 Nov 2024 10:59:20 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/24] linux-user/aarch64/mte: Include missing 'user/abitypes.h' header To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , Anton Johansson , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Thomas Huth , qemu-arm@nongnu.org, Peter Xu , Pierrick Bouvier , qemu-riscv@nongnu.org, David Hildenbrand , Peter Maydell , =?UTF-8?Q?Alex_Benn=C3=A9e?= , qemu-s390x@nongnu.org References: <20241114011310.3615-1-philmd@linaro.org> <20241114011310.3615-9-philmd@linaro.org> Content-Language: en-US From: Richard Henderson In-Reply-To: <20241114011310.3615-9-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/13/24 17:12, Philippe Mathieu-Daudé wrote: > abi_long type is defined in "user/abitypes.h". > Include it in order to avoid when refactoring: > > linux-user/aarch64/mte_user_helper.h:30:42: error: unknown type name ‘abi_long’; did you mean ‘u_long’? > 30 | void arm_set_mte_tcf0(CPUArchState *env, abi_long value); > | ^~~~~~~~ > | u_long > > Signed-off-by: Philippe Mathieu-Daudé > --- > linux-user/aarch64/mte_user_helper.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/linux-user/aarch64/mte_user_helper.h b/linux-user/aarch64/mte_user_helper.h > index 8685e5175a..0c53abda22 100644 > --- a/linux-user/aarch64/mte_user_helper.h > +++ b/linux-user/aarch64/mte_user_helper.h > @@ -9,6 +9,8 @@ > #ifndef AARCH64_MTE_USER_HELPER_H > #define AARCH64_MTE USER_HELPER_H > > +#include "user/abitypes.h" > + > #ifndef PR_MTE_TCF_SHIFT > # define PR_MTE_TCF_SHIFT 1 > # define PR_MTE_TCF_NONE (0UL << PR_MTE_TCF_SHIFT) Or maybe just switch to uint64_t. This is aarch64, so it's always going to be 64 bits. This is private between the prctl syscall and gdbstub. r~