From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFFF3C10F27 for ; Tue, 10 Mar 2020 11:01:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79D132465A for ; Tue, 10 Mar 2020 11:01:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WRAwJfCh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79D132465A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBcdo-0002aX-LA for qemu-devel@archiver.kernel.org; Tue, 10 Mar 2020 07:01:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48683) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBccj-0001i9-I3 for qemu-devel@nongnu.org; Tue, 10 Mar 2020 07:00:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBcch-00085G-Ux for qemu-devel@nongnu.org; Tue, 10 Mar 2020 07:00:33 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:44590 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBcch-00083E-RW for qemu-devel@nongnu.org; Tue, 10 Mar 2020 07:00:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583838030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4JG1xSI0M7SxiOdT+XP4LAA8ykTyWX0vFprHuiZRRDg=; b=WRAwJfChBlqQ/zxb4khPDLh4Mt4rCJGTl8Nv5pQn5cawzgf6pQGB/GgY4cvvbfa4h3Hv+4 5yRTa9wGV8uMN64e21lDHeIqa/ckXSMyRT763M/LO5kfbo5viYQWydTDaJ4zVfYCFo2Vxb Fl85efo6RQU6Y/1Eb6OjjjFpBFM53tw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-si_hbHt5POCEjnAl5TJIig-1; Tue, 10 Mar 2020 07:00:26 -0400 X-MC-Unique: si_hbHt5POCEjnAl5TJIig-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 95F1213EA; Tue, 10 Mar 2020 11:00:24 +0000 (UTC) Received: from [10.36.117.85] (ovpn-117-85.ams2.redhat.com [10.36.117.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 871E35C13D; Tue, 10 Mar 2020 11:00:21 +0000 (UTC) Subject: Re: [kvm-unit-tests PATCH v4 03/13] arm/arm64: gic: Introduce setup_irq() helper To: Andrew Jones References: <20200309102420.24498-1-eric.auger@redhat.com> <20200309102420.24498-4-eric.auger@redhat.com> <20200309105601.3hm2kfhuufgxoydl@kamzik.brq.redhat.com> From: Auger Eric Message-ID: <3e1e2c24-2f30-03f2-ca9c-a2d99aba0740@redhat.com> Date: Tue, 10 Mar 2020 12:00:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20200309105601.3hm2kfhuufgxoydl@kamzik.brq.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, thuth@redhat.com, kvm@vger.kernel.org, maz@kernel.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org, andre.przywara@arm.com, yuzenghui@huawei.com, alexandru.elisei@arm.com, kvmarm@lists.cs.columbia.edu, eric.auger.pro@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Drew, On 3/9/20 11:56 AM, Andrew Jones wrote: > On Mon, Mar 09, 2020 at 11:24:10AM +0100, Eric Auger wrote: >> ipi_enable() code would be reusable for other interrupts >> than IPI. Let's rename it setup_irq() and pass an interrupt >> handler pointer. >> >> Signed-off-by: Eric Auger >> >> --- >> >> v2 -> v3: >> - do not export setup_irq anymore >> --- >> arm/gic.c | 20 +++++++------------- >> 1 file changed, 7 insertions(+), 13 deletions(-) >> >> diff --git a/arm/gic.c b/arm/gic.c >> index fcf4c1f..abf08c7 100644 >> --- a/arm/gic.c >> +++ b/arm/gic.c >> @@ -34,6 +34,7 @@ static struct gic *gic; >> static int acked[NR_CPUS], spurious[NR_CPUS]; >> static int bad_sender[NR_CPUS], bad_irq[NR_CPUS]; >> static cpumask_t ready; >> +typedef void (*handler_t)(struct pt_regs *regs __unused); > > This is just irq_handler_fn, which is already defined in processor.h. > We don't need the __unused, not since 6b07148d06b1 ("Replace -Wextra > with a saner list of warning flags"). Shall I duplicate it into ./lib/arm/asm/processor.h as well? Thanks Eric > >> >> static void nr_cpu_check(int nr) >> { >> @@ -215,20 +216,20 @@ static void ipi_test_smp(void) >> report_prefix_pop(); >> } >> >> -static void ipi_enable(void) >> +static void setup_irq(handler_t handler) >> { >> gic_enable_defaults(); >> #ifdef __arm__ >> - install_exception_handler(EXCPTN_IRQ, ipi_handler); >> + install_exception_handler(EXCPTN_IRQ, handler); >> #else >> - install_irq_handler(EL1H_IRQ, ipi_handler); >> + install_irq_handler(EL1H_IRQ, handler); >> #endif >> local_irq_enable(); >> } >> >> static void ipi_send(void) >> { >> - ipi_enable(); >> + setup_irq(ipi_handler); >> wait_on_ready(); >> ipi_test_self(); >> ipi_test_smp(); >> @@ -238,7 +239,7 @@ static void ipi_send(void) >> >> static void ipi_recv(void) >> { >> - ipi_enable(); >> + setup_irq(ipi_handler); >> cpumask_set_cpu(smp_processor_id(), &ready); >> while (1) >> wfi(); >> @@ -295,14 +296,7 @@ static void ipi_clear_active_handler(struct pt_regs *regs __unused) >> static void run_active_clear_test(void) >> { >> report_prefix_push("active"); >> - gic_enable_defaults(); >> -#ifdef __arm__ >> - install_exception_handler(EXCPTN_IRQ, ipi_clear_active_handler); >> -#else >> - install_irq_handler(EL1H_IRQ, ipi_clear_active_handler); >> -#endif >> - local_irq_enable(); >> - >> + setup_irq(ipi_clear_active_handler); >> ipi_test_self(); >> report_prefix_pop(); >> } >> -- >> 2.20.1 >>