From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Connor Kuehl <ckuehl@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
virtio-fs@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
Mahmoud Mandour <ma.mandourr@gmail.com>
Subject: Re: [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd
Date: Wed, 28 Apr 2021 21:34:18 +0200 [thread overview]
Message-ID: <3e3fabf2-9fed-6d15-51b3-eb0c284852ac@redhat.com> (raw)
In-Reply-To: <a4dabeaf-4df8-2779-f028-3d135fe84bef@linaro.org>
On 4/28/21 9:24 PM, Richard Henderson wrote:
> On 4/28/21 10:56 AM, Philippe Mathieu-Daudé wrote:
>> Are you suggesting to remove the 'if have_block' check? This makes build
>> a the files pointlessly for user-mode-only builds...
>
> But since the objects are not included in the binary, I don't care.
>
> The build system is already too complex, and building a couple of extra
> small files makes only milliseconds of difference.
Maybe for libqemuutil.a (this does make a difference with the Python
QAPI generated files - another series).
I'll wait if we get to a consensus about what exactly is virtiofsd,
then revisit this series.
Thanks!
Phil.
next prev parent reply other threads:[~2021-04-28 19:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 14:48 [PATCH 0/2] virtiofsd: Meson build fixes Philippe Mathieu-Daudé
2021-04-28 14:48 ` [PATCH 1/2] meson: Check for seccomp/cap-ng libraries if virtiofsd is enabled Philippe Mathieu-Daudé
2021-04-28 15:06 ` Peter Maydell
2021-04-28 15:34 ` Philippe Mathieu-Daudé
2021-04-28 16:34 ` Richard Henderson
2021-04-28 18:00 ` Philippe Mathieu-Daudé
2021-04-28 18:36 ` Peter Maydell
2021-04-29 7:31 ` Philippe Mathieu-Daudé
2021-04-28 14:48 ` [PATCH 2/2] util/meson: Build iov/hexdump/buffer_is_zero with virtiofsd Philippe Mathieu-Daudé
2021-04-28 14:52 ` Philippe Mathieu-Daudé
2021-04-28 16:38 ` Richard Henderson
2021-04-28 17:56 ` Philippe Mathieu-Daudé
2021-04-28 19:24 ` Richard Henderson
2021-04-28 19:34 ` Philippe Mathieu-Daudé [this message]
2021-04-28 15:15 ` [PATCH 0/2] virtiofsd: Meson build fixes Peter Maydell
2021-04-28 16:52 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e3fabf2-9fed-6d15-51b3-eb0c284852ac@redhat.com \
--to=philmd@redhat.com \
--cc=berrange@redhat.com \
--cc=ckuehl@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ma.mandourr@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).