From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D901EC282DE for ; Mon, 10 Mar 2025 07:35:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1trXf8-0007mh-2E; Mon, 10 Mar 2025 03:34:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trXf3-0007m4-8s for qemu-devel@nongnu.org; Mon, 10 Mar 2025 03:34:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trXf1-0004cU-9P for qemu-devel@nongnu.org; Mon, 10 Mar 2025 03:34:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741592090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dz313aQQ/IowG7BeCWpg0VpL6pKaQq+pigoC6RQRdEo=; b=VRsrfhuAHqiw/N/2GLcOj7aSzo2n3/Jd952nZTeIUfwtnyDNM6dSOlRUGgB+5zhAxS7s2E c+yVsKTaj5UNxZLE3mAzpHARZ68y1JSZSEOYt85uBGq7/+ezJvra2P7JCT4UEqw0UqQqwj inIJOtVPgvcb1+L9q3uKrbHk+O3J/LE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-183-Y92WMQHhOF6JXiYlq7k8nw-1; Mon, 10 Mar 2025 03:34:48 -0400 X-MC-Unique: Y92WMQHhOF6JXiYlq7k8nw-1 X-Mimecast-MFC-AGG-ID: Y92WMQHhOF6JXiYlq7k8nw_1741592087 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3913aaf1e32so1195945f8f.0 for ; Mon, 10 Mar 2025 00:34:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741592087; x=1742196887; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Dz313aQQ/IowG7BeCWpg0VpL6pKaQq+pigoC6RQRdEo=; b=m1nhiqYd97BWDaBsbdNtDwAn8iljiNsUEMZp+w0B10+Z0Bewn5yKMZ3l8o17GOZnXn LMpuI442WnL6KBWaNkxy7J8hGksU3PVIjrKUI+2WL0ELHDqgedqLLra0Ymp3zR9SPJeh f6F7TEykCuUyOF4PtH9e702KnwCrCCBKuCRwI1ksvoGlgmL8HMlIP6fWrWKbF+0TEAz5 Y3bfPAmkThb0Sur45sCIqVhwHWbLl7sCLi2MIVmjcBY1K+iqqOESZYggRx+KWhfnfC+X TXMnKQmrdNxwlXQUNkHwOxzPisHjOO4HzDN0BmxzCuNL0QL/1MoWdTTL6MInLMIwvKjS lasw== X-Forwarded-Encrypted: i=1; AJvYcCUT1xyOI3r4s6TbXJ7OnnLHgpUF4USMrcv1oyg2dQxl8+wuww92NCu4o0GDeVQp5RyjyUEQ6bFqyrTX@nongnu.org X-Gm-Message-State: AOJu0YygzXTG2oTtNjCrsmDG7LwZO60REeoc1JQP+lK7SJIkTfNRG6Hp 7IGfIvaBtyCWQvxefZRaHY6NAWxulG7d/zue5wcUnX0EGKNyuf4//4FkA5xw1WsRgJE2X/UDb2N teFTi7yjZSUouBgnSvIE4SsJKXnf1wD/my5M/Xepth0Cw5q6JGgo2 X-Gm-Gg: ASbGncsEuhRx4Ylhe5w0r6MUHQKwTIbuv7pDn1OQl8J1IcC6bR67S9LhkK5NZq3/wjV rL+V2FYTmWRlZYt+Qr4ZzHM+UYF7XI0wzhi7pR9nDXcA3wdhKXs3N2lXzfWpXMFfVTBywX/85Y7 EhKo6YC2rv/KgZImwxMDdShIqinj1xVrwB02jJSfx5tfJe/ahj6kmBqGHc5MRutF/eW4MUxC0Hh c2cUrZ8h+qVDCjU8G36lY2BMtEQk/y5pBi8zT9UgxabarIJfB1kRXutfSTOI5Xd9VKOXxZhglsr IiAC3QNVsHUsg1nFklp+42zHpuFVjxwTneqXaXViOHOS7wlgWyDWQA== X-Received: by 2002:a5d:588b:0:b0:391:3f64:ecfe with SMTP id ffacd0b85a97d-3913f64f09cmr4033764f8f.10.1741592087464; Mon, 10 Mar 2025 00:34:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/9vthMo8AEU90kFige0JrYnRThAnEQF6LBET/nNW/s1psXS8HdHWQ1kSeeiFPvj4u59lm0w== X-Received: by 2002:a5d:588b:0:b0:391:3f64:ecfe with SMTP id ffacd0b85a97d-3913f64f09cmr4033745f8f.10.1741592087114; Mon, 10 Mar 2025 00:34:47 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c? ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c015d2bsm13680852f8f.43.2025.03.10.00.34.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Mar 2025 00:34:45 -0700 (PDT) Message-ID: <3e3ff63a-405c-462c-bea4-ea6383e546eb@redhat.com> Date: Mon, 10 Mar 2025 08:34:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] vfio/migration: Use BE byte order for device state wire packets To: "Maciej S. Szmigiero" , Peter Xu , Fabiano Rosas Cc: Alex Williamson , Eric Blake , Markus Armbruster , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Avihai Horon , Joao Martins , qemu-devel@nongnu.org References: Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/7/25 11:57, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > Wire data commonly use BE byte order (including in the existing migration > protocol), use it also for for VFIO device state packets. > > Fixes: 3228d311ab18 ("vfio/migration: Multifd device state transfer support - received buffers queuing") > Fixes: 6d644baef203 ("vfio/migration: Multifd device state transfer support - send side") > Signed-off-by: Maciej S. Szmigiero Maciej, Could you please resend this patch as a standalone patch ? and not as a reply on : https://lore.kernel.org/qemu-devel/cover.1741124640.git.maciej.szmigiero@oracle.com/ This is confusing b4. Thanks, C. > --- > hw/vfio/migration-multifd.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/hw/vfio/migration-multifd.c b/hw/vfio/migration-multifd.c > index a9d41b9f1cb1..e816461e1652 100644 > --- a/hw/vfio/migration-multifd.c > +++ b/hw/vfio/migration-multifd.c > @@ -13,6 +13,7 @@ > #include "hw/vfio/vfio-common.h" > #include "migration/misc.h" > #include "qapi/error.h" > +#include "qemu/bswap.h" > #include "qemu/error-report.h" > #include "qemu/lockable.h" > #include "qemu/main-loop.h" > @@ -208,12 +209,16 @@ bool vfio_multifd_load_state_buffer(void *opaque, char *data, size_t data_size, > return false; > } > > + packet->version = be32_to_cpu(packet->version); > if (packet->version != VFIO_DEVICE_STATE_PACKET_VER_CURRENT) { > error_setg(errp, "%s: packet has unknown version %" PRIu32, > vbasedev->name, packet->version); > return false; > } > > + packet->idx = be32_to_cpu(packet->idx); > + packet->flags = be32_to_cpu(packet->flags); > + > if (packet->idx == UINT32_MAX) { > error_setg(errp, "%s: packet index is invalid", vbasedev->name); > return false; > @@ -682,9 +687,9 @@ vfio_save_complete_precopy_thread_config_state(VFIODevice *vbasedev, > > packet_len = sizeof(*packet) + bioc->usage; > packet = g_malloc0(packet_len); > - packet->version = VFIO_DEVICE_STATE_PACKET_VER_CURRENT; > - packet->idx = idx; > - packet->flags = VFIO_DEVICE_STATE_CONFIG_STATE; > + packet->version = cpu_to_be32(VFIO_DEVICE_STATE_PACKET_VER_CURRENT); > + packet->idx = cpu_to_be32(idx); > + packet->flags = cpu_to_be32(VFIO_DEVICE_STATE_CONFIG_STATE); > memcpy(&packet->data, bioc->data, bioc->usage); > > if (!multifd_queue_device_state(idstr, instance_id, > @@ -734,7 +739,7 @@ vfio_multifd_save_complete_precopy_thread(SaveLiveCompletePrecopyThreadData *d, > } > > packet = g_malloc0(sizeof(*packet) + migration->data_buffer_size); > - packet->version = VFIO_DEVICE_STATE_PACKET_VER_CURRENT; > + packet->version = cpu_to_be32(VFIO_DEVICE_STATE_PACKET_VER_CURRENT); > > for (idx = 0; ; idx++) { > ssize_t data_size; > @@ -755,7 +760,7 @@ vfio_multifd_save_complete_precopy_thread(SaveLiveCompletePrecopyThreadData *d, > break; > } > > - packet->idx = idx; > + packet->idx = cpu_to_be32(idx); > packet_size = sizeof(*packet) + data_size; > > if (!multifd_queue_device_state(d->idstr, d->instance_id, >