From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5148BC433F5 for ; Mon, 11 Apr 2022 07:27:34 +0000 (UTC) Received: from localhost ([::1]:44386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndoSS-0003cb-So for qemu-devel@archiver.kernel.org; Mon, 11 Apr 2022 03:27:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndoOm-0001N7-B3 for qemu-devel@nongnu.org; Mon, 11 Apr 2022 03:23:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:47048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndoOj-0002RN-SP for qemu-devel@nongnu.org; Mon, 11 Apr 2022 03:23:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649661821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rqrTkjWH/Y9XIQAms3W3e8pg8X/QAI1vgK4VbhMhjzo=; b=Ck8xD7C7I0GgpAqLDikkggD03ZlOlyUjDTv+HKbHh8k0GCJP0iOeJNSNnzFb5b9kG+n6vc pc1SFbfhMfsrRp3etkzSxvTtNyWDMg0JdGrk3anmiw/q2cq8p8dFz+5DVSgjAvrlZ6X7f1 LjjvKH4TP0Cc4w5Wi2ZtDBpP6htpet8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-BPty8AJ6OpaNib8Hs8fM6Q-1; Mon, 11 Apr 2022 03:23:39 -0400 X-MC-Unique: BPty8AJ6OpaNib8Hs8fM6Q-1 Received: by mail-wm1-f70.google.com with SMTP id az9-20020a05600c600900b0038ea99858d8so4253427wmb.1 for ; Mon, 11 Apr 2022 00:23:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rqrTkjWH/Y9XIQAms3W3e8pg8X/QAI1vgK4VbhMhjzo=; b=MXFtxmsxr/7f0orTZTIj9BdvSqjP+dK3AUiCFBcZGQ3dxccbDgwWB81y/kelx7+cjf I5OAlLEyTfmiAF2OZ42yTCnPhJFpYkL0aBqFshVq/KiHmtC3ubzlUXoQuRIPFK9IXwGc fMS5RwywaqnVufV8R3WUg9tuVxLILdFlEvV5CF9vThAitV74CdA6FkV8Gcf/+0rOT81W 1RmxCtZyxOoV+ejGz6KWQUKDzwhOGxWZ2wwu80fDscxH3j2trd2es3uzIDulYQMjIDYJ EqjxDtzb27lPK9PXLSQFsOTwbvG6L0T3gMB8DU5Vop7TW67yyzm8p0TYJv7TZ5/zg9g2 iimg== X-Gm-Message-State: AOAM5333M7ZGy4yFizhxx7ywAlBW/CpcuAOcGa6I6jrhcREvSbgUlXK5 AVCFOLGG52zPUzVpzxdUvwTHibp+v4fphM1WozleZWjZxmZDOx6YaUbsoyW5/K6Cgxg7yzko+vm jCN2HDMnvUTwjUvo= X-Received: by 2002:a1c:1941:0:b0:38b:4af1:49f8 with SMTP id 62-20020a1c1941000000b0038b4af149f8mr28039043wmz.156.1649661817779; Mon, 11 Apr 2022 00:23:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOh4oqE00AqtgLrZhku5LJ7H1Mg28lSI7vQVP3p7DM1EKc1/63D+V7+jwtAy8TIP1oM/iEXQ== X-Received: by 2002:a1c:1941:0:b0:38b:4af1:49f8 with SMTP id 62-20020a1c1941000000b0038b4af149f8mr28039016wmz.156.1649661817509; Mon, 11 Apr 2022 00:23:37 -0700 (PDT) Received: from [192.168.42.76] (dynamic-046-114-150-143.46.114.pool.telefonica.de. [46.114.150.143]) by smtp.gmail.com with ESMTPSA id t12-20020a05600001cc00b00207aac5d595sm424930wrx.38.2022.04.11.00.23.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Apr 2022 00:23:36 -0700 (PDT) Message-ID: <3e4731dd-c066-71cb-fd4c-6cd2c205bbd7@redhat.com> Date: Mon, 11 Apr 2022 09:23:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v1] hw/ppc: change indentation to spaces from TABs To: Bin Meng References: <20220405121950.3528296-1-qtxuning1999@sjtu.edu.cn> From: Thomas Huth In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "open list:RISC-V" , Daniel Henrique Barboza , Greg Kurz , "qemu-devel@nongnu.org Developers" , qemu-ppc , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Guo Zhi , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/04/2022 08.57, Bin Meng wrote: > On Mon, Apr 11, 2022 at 2:45 PM Thomas Huth wrote: >> >> On 08/04/2022 21.19, Daniel Henrique Barboza wrote: >>> >>> >>> On 4/6/22 07:08, Bin Meng wrote: >>>> On Tue, Apr 5, 2022 at 10:36 PM Guo Zhi wrote: >>>>> >>>>> There are still some files in the QEMU PPC code base that use TABs for >>>>> indentation instead of using spaces. >>>>> The TABs should be replaced so that we have a consistent coding style. >>>>> >>>>> If this patch is applied, issue: >>>>> >>>>> https://gitlab.com/qemu-project/qemu/-/issues/374 >>>>> >>>>> can be closed. >>> >>> Please add the following tag in the commit: >>> >>> >>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/374 >>> >>> >>> This will make Gitlab automatically close the issue when the patch is accepted. >>> >>>>> >>>>> Signed-off-by: Guo Zhi >>>>> --- >>>>> hw/core/uboot_image.h | 185 ++++++++++++++++++++--------------------- >>>>> hw/ppc/ppc440_bamboo.c | 6 +- >>>>> hw/ppc/spapr_rtas.c | 18 ++-- >>>>> include/hw/ppc/ppc.h | 10 +-- >>>>> 4 files changed, 109 insertions(+), 110 deletions(-) >>>>> >>>>> diff --git a/hw/core/uboot_image.h b/hw/core/uboot_image.h >>>> >>>> uboot_image.h was taken from the U-Boot source, I believe it should be >>>> kept as it is. >>> >>> >>> (CCing Thomas since het explictly listed hw/core/uboot_image.h in the bug) >>> >>> >>> I am not sure about keeping this file as is. >> >> Seems like uboot_image.h has originally been taken from U-Boot's >> include/image.h file ... but the two files are completely out of sync >> nowadays, e.g. U-Boot switched to enums instead of #defines at one point in >> time. So I think it does not make much sense to keep the TABs in here, and >> I'd rather like to see them replaced with spaces indeed. > > This file has been sync'ed recently. > > See http://patchwork.ozlabs.org/project/qemu-devel/patch/20220324134812.541274-1-bmeng.cn@gmail.com/ Oh, ok, thanks, good to know. So we should maybe really rather drop the uboot_image.h from the whitespace cleanup here, indeed (and rather add a comment to the header file instead that this is a file that is sync'ed with U-Boot and thus does not follow the QEMU coding conventions?) Anyway, seems like that u-boot sync patch felt through the cracks, likely since it was not quite clear which tree it should go through ... ARM? PPC? RISC-V? Thomas