From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: Cleber Rosa <crosa@redhat.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Beraldo Leal <bleal@redhat.com>,
Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>,
Paolo Bonzini <pbonzini@redhat.com>,
Eric Auger <eric.auger@redhat.com>,
qemu-arm@nongnu.org
Subject: Re: [PATCH] tests/avocado: Move LinuxTest related code into a separate file
Date: Wed, 21 Aug 2024 17:11:32 +0200 [thread overview]
Message-ID: <3e530db3-99e2-4878-a927-e6eebc0f92fe@linaro.org> (raw)
In-Reply-To: <20240719095031.32814-1-thuth@redhat.com>
On 19/7/24 11:50, Thomas Huth wrote:
> Only some few tests are using the LinuxTest class. Move the related
> code into a separate file so that this does not pollute the main
> namespace.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/avocado/avocado_qemu/__init__.py | 239 +---------------------
> tests/avocado/avocado_qemu/linuxtest.py | 253 ++++++++++++++++++++++++
> tests/avocado/boot_linux.py | 3 +-
> tests/avocado/hotplug_blk.py | 2 +-
> tests/avocado/hotplug_cpu.py | 2 +-
> tests/avocado/intel_iommu.py | 2 +-
> tests/avocado/replay_linux.py | 2 +-
> tests/avocado/smmu.py | 3 +-
> 8 files changed, 262 insertions(+), 244 deletions(-)
> create mode 100644 tests/avocado/avocado_qemu/linuxtest.py
>
> diff --git a/tests/avocado/avocado_qemu/__init__.py b/tests/avocado/avocado_qemu/__init__.py
> index 304c428168..a3da2a96bb 100644
> --- a/tests/avocado/avocado_qemu/__init__.py
> +++ b/tests/avocado/avocado_qemu/__init__.py
> @@ -10,7 +10,6 @@
>
> import logging
> import os
> -import shutil
> import subprocess
> import sys
> import tempfile
> @@ -18,7 +17,7 @@
> import uuid
>
> import avocado
> -from avocado.utils import cloudinit, datadrainer, process, ssh, vmimage
> +from avocado.utils import ssh
Unfortunately we don't run the user mode tests on CI and missed
'process' is used by the QemuUserTest class.
next prev parent reply other threads:[~2024-08-21 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 9:50 [PATCH] tests/avocado: Move LinuxTest related code into a separate file Thomas Huth
2024-07-19 10:03 ` Daniel P. Berrangé
2024-07-19 12:49 ` Philippe Mathieu-Daudé
2024-07-19 15:09 ` Philippe Mathieu-Daudé
2024-08-21 15:11 ` Philippe Mathieu-Daudé [this message]
2024-08-21 15:14 ` Thomas Huth
2024-08-26 16:11 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e530db3-99e2-4878-a927-e6eebc0f92fe@linaro.org \
--to=philmd@linaro.org \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=eric.auger@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).