From: WANG Xuerui <i.qemu@xen0n.name>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Kyle Evans <kevans@freebsd.org>,
Richard Henderson <richard.henderson@linaro.org>,
Laurent Vivier <laurent@vivier.eu>,
Paolo Bonzini <pbonzini@redhat.com>, Warner Losh <imp@bsdimp.com>
Subject: Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host
Date: Mon, 27 Sep 2021 10:59:31 +0800 [thread overview]
Message-ID: <3e568166-8a73-7c1e-9d83-38b907fab39d@xen0n.name> (raw)
In-Reply-To: <92569fc0-2c0e-fa91-d9c8-d1345741a68b@xen0n.name>
On 9/27/21 10:42, WANG Xuerui wrote:
> On 9/27/21 06:01, Philippe Mathieu-Daudé wrote:
>> Reported-by: Warner Losh <imp@bsdimp.com>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> bsd-user/meson.build | 4 ++++
>> 1 file changed, 4 insertions(+)
>
> I'm newcomer here, but this is just 4 lines of Meson, and two similar
> usages already exist within QEMU proper so...
>
> Reviewed-by: WANG Xuerui <git@xen0n.name>
>
>
Hmm, other replies pointed out that one can also make the top-level
subdir() call conditional... And we seem to have more than 2 usages
following the latter pattern instead. However putting the conditional in
sub-directory makes the logic localized, which is arguably more friendly
to someone casually browsing the source code.
As both ways work, I think maybe being consistent and moving things to
top-level meson.build has more value?
next prev parent reply other threads:[~2021-09-27 3:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 22:01 [PATCH 0/2] user-mode: Avoid processing unnecessary meson rules Philippe Mathieu-Daudé
2021-09-26 22:01 ` [PATCH 1/2] bsd-user: Only process meson rules on BSD host Philippe Mathieu-Daudé
2021-09-26 23:08 ` Richard Henderson
2021-09-26 23:31 ` Warner Losh
2021-09-27 5:24 ` Philippe Mathieu-Daudé
2021-10-05 19:16 ` Paolo Bonzini
2021-09-27 2:42 ` WANG Xuerui
2021-09-27 2:59 ` WANG Xuerui [this message]
2021-09-27 9:14 ` Peter Maydell
2021-09-27 9:40 ` Philippe Mathieu-Daudé
2021-09-27 9:54 ` Peter Maydell
2021-10-05 19:23 ` Paolo Bonzini
2021-10-05 18:28 ` Alex Bennée
2021-09-27 9:52 ` Daniel P. Berrangé
2021-09-27 10:07 ` Peter Maydell
2021-09-27 10:53 ` Warner Losh
2021-10-05 19:26 ` Paolo Bonzini
2021-10-05 20:41 ` Laurent Vivier
2021-10-05 20:46 ` Warner Losh
2021-10-06 6:02 ` Laurent Vivier
2021-09-26 22:01 ` [PATCH 2/2] linux-user: Only process meson rules on Linux host Philippe Mathieu-Daudé
2021-09-27 2:42 ` WANG Xuerui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e568166-8a73-7c1e-9d83-38b907fab39d@xen0n.name \
--to=i.qemu@xen0n.name \
--cc=f4bug@amsat.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).