From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x <qemu-s390x@nongnu.org>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Cornelia Huck <cohuck@redhat.com>,
David Hildenbrand <david@redhat.com>,
Halil Pasic <pasic@linux.vnet.ibm.com>,
Janosch Frank <frankja@linux.vnet.ibm.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear
Date: Thu, 1 Mar 2018 09:44:25 +0100 [thread overview]
Message-ID: <3e73ea6e-d8c0-4d10-ce9f-a000498df345@redhat.com> (raw)
In-Reply-To: <79f7059b-f2d3-a758-6bb9-29433b31b313@redhat.com>
On 01/03/2018 04:58, Thomas Huth wrote:
>> When a guests reboots with diagnose 308 subcode 3 it requests the memory
>> to be cleared. We did not do it so far. This does not only violate the
>> architecture, it also misses the chance to free up that memory on
>> reboot, which would help on host memory over commitment. By using
>> ram_block_discard_range we can cover both cases.
>
> Sounds like a good idea. I wonder whether that release_all_ram()
> function should maybe rather reside in exec.c, so that other machines
> that want to clear all RAM at reset time can use it, too?
Either way is fine for me. With s/rams/ram/ the s390-only patch is ok.
Paolo
next prev parent reply other threads:[~2018-03-01 8:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 19:53 [Qemu-devel] [PATCH 1/1] s390/kvm: implement clearing part of IPL clear Christian Borntraeger
2018-03-01 3:58 ` Thomas Huth
2018-03-01 7:37 ` Christian Borntraeger
2018-03-01 8:44 ` Paolo Bonzini [this message]
2018-03-01 9:24 ` Dr. David Alan Gilbert
2018-03-01 11:00 ` Christian Borntraeger
2018-03-01 11:45 ` Dr. David Alan Gilbert
2018-03-01 12:08 ` Christian Borntraeger
2018-03-01 12:28 ` Dr. David Alan Gilbert
2018-03-01 12:35 ` Christian Borntraeger
2018-03-01 12:39 ` Christian Borntraeger
2018-03-01 12:58 ` Dr. David Alan Gilbert
2018-03-01 12:49 ` Dr. David Alan Gilbert
2018-03-01 9:21 ` David Hildenbrand
2018-03-05 12:54 ` Cornelia Huck
2018-03-05 13:04 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e73ea6e-d8c0-4d10-ce9f-a000498df345@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).