qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com, amit@kernel.org
Subject: Re: [PATCH] replay: rng-builtin support
Date: Wed, 3 Feb 2021 08:42:23 +0100	[thread overview]
Message-ID: <3e9bfe1c-4df2-496b-a4af-5c8cb7d3e9b4@redhat.com> (raw)
In-Reply-To: <161233201286.170686.7858208964037376305.stgit@pasha-ThinkPad-X280>

On 03/02/21 07:00, Pavel Dovgalyuk wrote:
> This patch enables using rng-builtin with record/replay
> by making the callbacks deterministic.
> 
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> ---
>   backends/rng-builtin.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/backends/rng-builtin.c b/backends/rng-builtin.c
> index f38dff117d..f367eb665c 100644
> --- a/backends/rng-builtin.c
> +++ b/backends/rng-builtin.c
> @@ -10,6 +10,7 @@
>   #include "qemu/main-loop.h"
>   #include "qemu/guest-random.h"
>   #include "qom/object.h"
> +#include "sysemu/replay.h"
>   
>   OBJECT_DECLARE_SIMPLE_TYPE(RngBuiltin, RNG_BUILTIN)
>   
> @@ -37,7 +38,7 @@ static void rng_builtin_request_entropy(RngBackend *b, RngRequest *req)
>   {
>       RngBuiltin *s = RNG_BUILTIN(b);
>   
> -    qemu_bh_schedule(s->bh);
> +    replay_bh_schedule_event(s->bh);
>   }
>   
>   static void rng_builtin_init(Object *obj)
> 

Queued, thanks.

Paolo



      reply	other threads:[~2021-02-03  7:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03  6:00 [PATCH] replay: rng-builtin support Pavel Dovgalyuk
2021-02-03  7:42 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e9bfe1c-4df2-496b-a4af-5c8cb7d3e9b4@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=amit@kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pavel.dovgalyuk@ispras.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).