From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50441E81DE8 for ; Fri, 6 Oct 2023 11:43:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qojE4-0004H2-KG; Fri, 06 Oct 2023 07:42:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qojE2-00043O-UA for qemu-devel@nongnu.org; Fri, 06 Oct 2023 07:42:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qojE1-0001zg-07 for qemu-devel@nongnu.org; Fri, 06 Oct 2023 07:42:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696592552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6tSTt+41MC27E89KcYYOn6PrKCXSNySiN6NLqSP3g68=; b=jWudaPW0mMbDP8WBdXWGymhNQZJ6rPHZxV6G22h+vcUx7TZbD8pgVPHCyh0XtdST3aL3pt R+6cx6f18ZLSytSCdDnsTSXw+FH9exntreq7rpo2lWkOH8PRJ7UwczdnkEma4oCbd4KXXy PnRcM+PLVtynubHy2A6N8WdfIEnm4nM= Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com [209.85.160.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-YjGBAsLhMACFK5-sQn7obQ-1; Fri, 06 Oct 2023 07:42:21 -0400 X-MC-Unique: YjGBAsLhMACFK5-sQn7obQ-1 Received: by mail-oa1-f70.google.com with SMTP id 586e51a60fabf-1dd691b1037so3026945fac.3 for ; Fri, 06 Oct 2023 04:42:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696592540; x=1697197340; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6tSTt+41MC27E89KcYYOn6PrKCXSNySiN6NLqSP3g68=; b=qb/TWg9R9mVidJW2B5FI1zGl77EewgPN5gVRSt7JmvVRw5wi86VUY8CH2zJyuDsN1n JAv4taFqWfEwIadMYT0Nv1AxzLNlBnq8KwCtWfVQh0z96EjvTdDNbYK5PrSLN+4O/QIr 2Jm52xiw+szK1kwYtWhldtFg2QyFz4hQ4mdBNC90GbXm/amBVFaAN/fkqjE9k6JjlKb5 yWqyAgoBZsnUlihJwT+zDgTiPckcN7MDxF/EsRsC2CmtEbiIlHVjePmOkE+XX+zOVc3q 6ykqr5ItACNNxsWfnkOqLFcQ2Mnk/fknotH/Kv5nKFSd7QSF0WzDWzCczGYBzg2M8vFU 0EuQ== X-Gm-Message-State: AOJu0Yy3DEmUjz51ryi/v+N5G2jq4d2VMs+6NxI4QB625dslvrtOBW/A FHLZAzRih8RltC4VUnELUhRc0yEOmsqFSbmanWgOBi2jWNKrpScDbEd42chCqQciTtROa+U8BBH 3j4cxeGVDaq/e5JA= X-Received: by 2002:a05:6870:9602:b0:1dd:443c:57a8 with SMTP id d2-20020a056870960200b001dd443c57a8mr9730957oaq.26.1696592540561; Fri, 06 Oct 2023 04:42:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEaMW/532IKr6u7AiCODXZ9V/5ARo6x4qtV3NNU1qo+NML+i0r3eP8Xiej36wAOyoGYH6Y1Nw== X-Received: by 2002:a05:6870:9602:b0:1dd:443c:57a8 with SMTP id d2-20020a056870960200b001dd443c57a8mr9730946oaq.26.1696592540310; Fri, 06 Oct 2023 04:42:20 -0700 (PDT) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id t10-20020a0ca68a000000b00668eb252523sm1305287qva.63.2023.10.06.04.42.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 04:42:19 -0700 (PDT) Message-ID: <3ea30f06-aeea-8e66-a8ed-75a9292a415f@redhat.com> Date: Fri, 6 Oct 2023 13:42:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PULL 00/21] vfio queue Content-Language: en-US To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , qemu-devel@nongnu.org, Stefan Hajnoczi Cc: Alex Williamson , Matthew Rosato References: <20231006062005.1040296-1-clg@redhat.com> <1e2652d6-c10b-9b65-6e2c-7903574d501a@redhat.com> From: Eric Auger In-Reply-To: <1e2652d6-c10b-9b65-6e2c-7903574d501a@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=eauger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -48 X-Spam_score: -4.9 X-Spam_bar: ---- X-Spam_report: (-4.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.797, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Cédric, On 10/6/23 12:33, Cédric Le Goater wrote: > On 10/6/23 08:19, Cédric Le Goater wrote: >> The following changes since commit >> 2f3913f4b2ad74baeb5a6f1d36efbd9ecdf1057d: >> >>    Merge tag 'for_upstream' of >> https://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging >> (2023-10-05 09:01:01 -0400) >> >> are available in the Git repository at: >> >>    https://github.com/legoater/qemu/ tags/pull-vfio-20231006 >> >> for you to fetch changes up to 6e86aaef9ac57066aa923211a164df95b7b3cdf7: >> >>    vfio/common: Move legacy VFIO backend code into separate >> container.c (2023-10-05 22:04:52 +0200) >> >> ---------------------------------------------------------------- >> vfio queue: >> >> * Fix for VFIO display when using Intel vGPUs >> * Support for dynamic MSI-X >> * Preliminary work for IOMMUFD support > > Stefan, > > I just did some tests on z with passthough devices (PCI and AP) and > the series is not bisectable. QEMU crashes at patch  : > >   "vfio/pci: Introduce vfio_[attach/detach]_device". > > Also, with everything applied, the guest fails to start with : > >  vfio: IRQ 0 not available (number of irqs 0) > > So, please hold on and sorry for the noise. I will start digging > on my side. I just tested with the head on vfio/pci: Introduce vfio_[attach/detach]_device, with PCIe assignment on ARM and I fail to reproduce the crash. Do you try hotplug or something simpler? Thanks Eric > > Thanks, > > C. > >> ---------------------------------------------------------------- >> Alex Williamson (1): >>        vfio/display: Fix missing update to set backing fields >> >> Eric Auger (7): >>        scripts/update-linux-headers: Add iommufd.h >>        vfio/common: Propagate KVM_SET_DEVICE_ATTR error if any >>        vfio/common: Introduce vfio_container_add|del_section_window() >>        vfio/pci: Introduce vfio_[attach/detach]_device >>        vfio/platform: Use vfio_[attach/detach]_device >>        vfio/ap: Use vfio_[attach/detach]_device >>        vfio/ccw: Use vfio_[attach/detach]_device >> >> Jing Liu (4): >>        vfio/pci: detect the support of dynamic MSI-X allocation >>        vfio/pci: enable vector on dynamic MSI-X allocation >>        vfio/pci: use an invalid fd to enable MSI-X >>        vfio/pci: enable MSI-X in interrupt restoring on dynamic >> allocation >> >> Yi Liu (2): >>        vfio/common: Move IOMMU agnostic helpers to a separate file >>        vfio/common: Move legacy VFIO backend code into separate >> container.c >> >> Zhenzhong Duan (7): >>        vfio/pci: rename vfio_put_device to vfio_pci_put_device >>        linux-headers: Add iommufd.h >>        vfio/common: Extract out vfio_kvm_device_[add/del]_fd >>        vfio/common: Move VFIO reset handler registration to a group >> agnostic function >>        vfio/common: Introduce a per container device list >>        vfio/common: Store the parent container in VFIODevice >>        vfio/common: Introduce a global VFIODevice list >> >>   hw/vfio/pci.h                   |    1 + >>   include/hw/vfio/vfio-common.h   |   60 +- >>   linux-headers/linux/iommufd.h   |  444 +++++++++ >>   hw/vfio/ap.c                    |   69 +- >>   hw/vfio/ccw.c                   |  122 +-- >>   hw/vfio/common.c                | 1885 >> +++------------------------------------ >>   hw/vfio/container.c             | 1161 ++++++++++++++++++++++++ >>   hw/vfio/display.c               |    2 + >>   hw/vfio/helpers.c               |  612 +++++++++++++ >>   hw/vfio/pci.c                   |  194 ++-- >>   hw/vfio/platform.c              |   43 +- >>   hw/vfio/meson.build             |    2 + >>   hw/vfio/trace-events            |    6 +- >>   scripts/update-linux-headers.sh |    3 +- >>   14 files changed, 2580 insertions(+), 2024 deletions(-) >>   create mode 100644 linux-headers/linux/iommufd.h >>   create mode 100644 hw/vfio/container.c >>   create mode 100644 hw/vfio/helpers.c >> >