From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF4eD-0007TV-Rx for qemu-devel@nongnu.org; Mon, 20 Jun 2016 15:14:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF4eB-0006y3-Rg for qemu-devel@nongnu.org; Mon, 20 Jun 2016 15:14:12 -0400 References: From: Max Reitz Message-ID: <3eab390d-9efa-a8a7-74cb-b6509b66964f@redhat.com> Date: Mon, 20 Jun 2016 21:14:04 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l5iofiOtqk4ajd3P1V13VsHmFVo8DVETd" Subject: Re: [Qemu-devel] [PATCH 15/15] blockjob: Add 'id' field to 'BlockJobInfo' and all BLOCK_JOB_* events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Eric Blake , Jeff Cody This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --l5iofiOtqk4ajd3P1V13VsHmFVo8DVETd From: Max Reitz To: Alberto Garcia , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Eric Blake , Jeff Cody Message-ID: <3eab390d-9efa-a8a7-74cb-b6509b66964f@redhat.com> Subject: Re: [PATCH 15/15] blockjob: Add 'id' field to 'BlockJobInfo' and all BLOCK_JOB_* events References: In-Reply-To: Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 09.06.2016 10:20, Alberto Garcia wrote: > Now that all jobs have an ID and all QMP commands that create and > operate on block jobs can specify one we can finally expose the ID in > all BLOCK_JOB_* events and the BlockJobInfo structure. >=20 > This modifies the output of several iotests, but now we have full > control of the job IDs so this patch updates the affected ones. >=20 > Signed-off-by: Alberto Garcia > --- > blockjob.c | 6 +++++- > docs/qmp-events.txt | 4 ++++ > qapi/block-core.json | 18 ++++++++++++++++-- > tests/qemu-iotests/095 | 2 +- > tests/qemu-iotests/095.out | 2 +- > tests/qemu-iotests/124 | 3 ++- > tests/qemu-iotests/141 | 6 +++++- > tests/qemu-iotests/141.out | 14 +++++++------- > tests/qemu-iotests/144 | 1 + > tests/qemu-iotests/144.out | 4 ++-- > 10 files changed, 44 insertions(+), 16 deletions(-) Looks good, but in the meantime iotest 156 has been added which needs the same treatment as the rest. Also, I personally wouldn't mind making use of the IDs where trivial. For example, you can just replace the "'device': 'virtio0'" by "'id': 'commit1'" in the block-job-complete invocation in 144. Optional, of course, but would make sense. Max --l5iofiOtqk4ajd3P1V13VsHmFVo8DVETd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXaEB8AAoJEDuxQgLoOKytrloH/3kpVILcmNag7H0ZN4+p3oY7 lsVzRAZdtpO6NuOcnHI3eA+ZPTM11mm909EEJiFqF/v+3YzbV9pFZ7R0GUhsl91f rlKCa0FCktHmQGFm7gv1S0tHnqnuLCsMYbKn7jal/8dzj9EMlry4Iw8ffknXISRx 6xb/NV0dVa4/w9/EM6NPYBlWr0ZVhMJv1XWCVFKxuXYX/SqwLf8YNJPcfCsIesqy PruZHSlYomlh+9DWSNc85WedHM5dgzCuahA76d5OCFScPknZd1JO8iyI98fgDjet JNMn9vHfw6oBUmeapCOd13KQacQs+qeW83RIYWSu3pelbwBqrlRCk4nxf5HUwhU= =1M55 -----END PGP SIGNATURE----- --l5iofiOtqk4ajd3P1V13VsHmFVo8DVETd--