From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqE3w-0007jT-5j for qemu-devel@nongnu.org; Thu, 16 Aug 2018 04:55:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqE3r-0007PT-2m for qemu-devel@nongnu.org; Thu, 16 Aug 2018 04:55:24 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:44581) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fqE3o-0007Ko-OJ for qemu-devel@nongnu.org; Thu, 16 Aug 2018 04:55:17 -0400 Received: by mail-wr1-x441.google.com with SMTP id r16-v6so3410284wrt.11 for ; Thu, 16 Aug 2018 01:55:14 -0700 (PDT) References: <0c215752-5cd2-3b7c-bc3c-f435f1dbbfed@bluestop.org> <8bf07395-4872-ce74-c201-9fca232edd01@gmail.com> <80532e46-ffbf-9c87-5296-741bbb6f83ac@redhat.com> <1feb3cc1-86ee-f708-6dc7-b9e20a7588ac@redhat.com> <327f3e04-dd5b-06bd-f672-5f180521db32@gmx.com> From: Marcel Apfelbaum Message-ID: <3ed5e351-80be-9707-773d-0b65a7e0b4dc@gmail.com> Date: Thu, 16 Aug 2018 11:55:10 +0300 MIME-Version: 1.0 In-Reply-To: <327f3e04-dd5b-06bd-f672-5f180521db32@gmx.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kamil Rytarowski , Thomas Huth , Rebecca Cran , qemu-devel@nongnu.org Cc: Peter Maydell , Yuval Shaia , Brad Smith On 08/15/2018 04:37 PM, Kamil Rytarowski wrote: > On 06.08.2018 10:51, Thomas Huth wrote: >> On 07/28/2018 05:50 AM, Rebecca Cran wrote: >>> On 7/25/18 5:14 AM, Thomas Huth wrote: >>> >>>> Note that the error has been reported to happen on FreeBSD - so I doubt >>>> that this header should be here. >>>> >>>> Anyway, our include/standard-headers/linux/types.h is also empty ... so >>>> could you try whether it compiles if you simply remove this #include >>>> line, Rebecca? >>> >>> Sorry for the delay, I'm just getting back to this. Removing the include >>> causes it to fail later on, with: >>> >>> /home/bcran/workspace/qemu/hw/rdma/vmw/pvrdma_cmd.c:60:17: warning: >>> implicit declaration of function 'mremap' is invalid in C99 >>> [-Wimplicit-function-declaration] >>>     host_virt = mremap(curr_page, 0, length, MREMAP_MAYMOVE); >> OK, thanks for checking. According to >> >> https://www.freebsd.org/cgi/man.cgi?query=mremap&manpath=NetBSD+5.0 >> >> that syscall should also be available on FreeBSD. So could you please do >> one more test and see whether it works when you add the following line >> somewhere at the beginning of the file: >> >> #include >> >> Thanks, >> Thomas >> > I'm a little bit disoriented. The linked page is from NetBSD in a very > old version 5.x. We have 8.0 out now. > > The thread is about FreeBSD. If there are any questions regarding > NetBSD, please let me know. Indeed, the linked page didn't help, we are referring to FreeBSD which doesn't support mremap, at least by default. Thanks, Marcel