From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: pbonzini@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
den@virtuozzo.com, rjones@redhat.com, berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation
Date: Wed, 3 Oct 2018 15:44:56 -0500 [thread overview]
Message-ID: <3ee51f9a-5c6d-00fd-068c-9915579ad15b@redhat.com> (raw)
In-Reply-To: <20181003170228.95973-1-vsementsov@virtuozzo.com>
On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote:
> It's unexpected behavior that without -x option qemu-nbd do old-style
> negotiation. Let's use "" as a default name instead (as it is already
> done if tls is used) and therefore, drop old-style negotiation from
> Qemu NBD server.
>
> Vladimir Sementsov-Ogievskiy (2):
> qemu-nbd: drop old-style negotiation
> nbd/server: drop old-style negotiation
>
> include/block/nbd.h | 3 +--
> blockdev-nbd.c | 2 +-
> nbd/server.c | 53 +++++++++++++--------------------------------
> qemu-nbd.c | 25 +++++----------------
> 4 files changed, 23 insertions(+), 60 deletions(-)
>
Thanks; applying this series to my NBD queue.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2018-10-03 20:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 17:02 [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation Vladimir Sementsov-Ogievskiy
2018-10-03 17:02 ` [Qemu-devel] [PATCH 1/2] qemu-nbd: " Vladimir Sementsov-Ogievskiy
2018-10-03 17:31 ` Eric Blake
2018-10-03 17:02 ` [Qemu-devel] [PATCH 2/2] nbd/server: " Vladimir Sementsov-Ogievskiy
2018-10-03 17:35 ` Eric Blake
2018-10-03 17:32 ` [Qemu-devel] [PATCH 0/2] nbd server: " Eric Blake
2018-10-03 17:59 ` Vladimir Sementsov-Ogievskiy
2018-10-03 18:08 ` Eric Blake
2018-10-03 20:30 ` Richard W.M. Jones
2018-10-04 12:10 ` Vladimir Sementsov-Ogievskiy
2018-10-04 12:22 ` Richard W.M. Jones
2018-10-03 20:44 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ee51f9a-5c6d-00fd-068c-9915579ad15b@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=den@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).