From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Martin Kletzander <mkletzan@redhat.com>
Subject: Re: [PATCH trivial] audio/audio.c: remove trailing newline in error_setg
Date: Wed, 3 Jan 2024 12:32:15 +0100 [thread overview]
Message-ID: <3eeb7394-d138-4a27-b2d3-0b6aeb9c5205@linaro.org> (raw)
In-Reply-To: <20240103111800.250151-1-mjt@tls.msk.ru>
On 3/1/24 12:18, Michael Tokarev wrote:
> error_setg() appends newline to the formatted message.
> Fixes: cb94ff5f80c5
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> audio/audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/audio/audio.c b/audio/audio.c
> index 8d1e4ad922..7ac74f9e16 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -1744,7 +1744,7 @@ static AudioState *audio_init(Audiodev *dev, Error **errp)
> if (driver) {
> done = !audio_driver_init(s, driver, dev, errp);
> } else {
> - error_setg(errp, "Unknown audio driver `%s'\n", drvname);
> + error_setg(errp, "Unknown audio driver `%s'", drvname);
> }
> if (!done) {
> goto out;
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2024-01-03 11:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 11:18 [PATCH trivial] audio/audio.c: remove trailing newline in error_setg Michael Tokarev
2024-01-03 11:32 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eeb7394-d138-4a27-b2d3-0b6aeb9c5205@linaro.org \
--to=philmd@linaro.org \
--cc=mjt@tls.msk.ru \
--cc=mkletzan@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).