* [PATCH trivial] audio/audio.c: remove trailing newline in error_setg
@ 2024-01-03 11:18 Michael Tokarev
2024-01-03 11:32 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Michael Tokarev @ 2024-01-03 11:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Michael Tokarev, qemu-trivial
error_setg() appends newline to the formatted message.
Fixes: cb94ff5f80c5
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
audio/audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/audio/audio.c b/audio/audio.c
index 8d1e4ad922..7ac74f9e16 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1744,7 +1744,7 @@ static AudioState *audio_init(Audiodev *dev, Error **errp)
if (driver) {
done = !audio_driver_init(s, driver, dev, errp);
} else {
- error_setg(errp, "Unknown audio driver `%s'\n", drvname);
+ error_setg(errp, "Unknown audio driver `%s'", drvname);
}
if (!done) {
goto out;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH trivial] audio/audio.c: remove trailing newline in error_setg
2024-01-03 11:18 [PATCH trivial] audio/audio.c: remove trailing newline in error_setg Michael Tokarev
@ 2024-01-03 11:32 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-01-03 11:32 UTC (permalink / raw)
To: Michael Tokarev, qemu-devel; +Cc: qemu-trivial, Martin Kletzander
On 3/1/24 12:18, Michael Tokarev wrote:
> error_setg() appends newline to the formatted message.
> Fixes: cb94ff5f80c5
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> audio/audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/audio/audio.c b/audio/audio.c
> index 8d1e4ad922..7ac74f9e16 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -1744,7 +1744,7 @@ static AudioState *audio_init(Audiodev *dev, Error **errp)
> if (driver) {
> done = !audio_driver_init(s, driver, dev, errp);
> } else {
> - error_setg(errp, "Unknown audio driver `%s'\n", drvname);
> + error_setg(errp, "Unknown audio driver `%s'", drvname);
> }
> if (!done) {
> goto out;
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-03 11:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-03 11:18 [PATCH trivial] audio/audio.c: remove trailing newline in error_setg Michael Tokarev
2024-01-03 11:32 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).