From: Thomas Huth <thuth@redhat.com>
To: Hanna Reitz <hreitz@redhat.com>,
Qemu-block <qemu-block@nongnu.org>, Kevin Wolf <kwolf@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: Failure in iotest 183
Date: Tue, 5 Jul 2022 12:20:21 +0200 [thread overview]
Message-ID: <3efdf6ae-1ace-6db6-e947-e6288c41acd7@redhat.com> (raw)
In-Reply-To: <308c543a-5f72-b0f4-15d4-b98d4db6f4f2@redhat.com>
On 05/07/2022 11.58, Hanna Reitz wrote:
> On 05.07.22 11:35, Thomas Huth wrote:
>>
>> Hi!
>>
>> I've just hit a failure in iotest 183:
>>
>> --- /home/thuth/devel/qemu/tests/qemu-iotests/183.out
>> +++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch/183/183.out.bad
>> @@ -30,7 +30,7 @@
>> 'arguments': { 'uri': 'unix:SOCK_DIR/migrate', 'blk': true } }
>> {"return": {}}
>> { 'execute': 'query-status' }
>> -{"return": {"status": "postmigrate", "singlestep": false, "running": false}}
>> +{"return": {"status": "completed", "setup-time": 0, "downtime": 2448,
>> "total-time": 2872, "ram": {"total": 134750208, "postcopy-requests": 0,
>> "dirty-sync-count": 3, "multifd-bytes": 0, "pages-per-second": 0,
>> "downtime-bytes": 0, "page-size": 4096, "remaining": 0, "postcopy-bytes":
>> 0, "mbps": 188.63209192200557, "transferred": 496829, "precopy-bytes":
>> 496829, "duplicate": 32849, "dirty-pages-rate": 0, "skipped": 0,
>> "normal-bytes": 200704, "normal": 49}}}
>
> Weird because query-status cannot return something with '"status":
> "completed"' in it. We can see the '"status": "postmigrate"' object
> somewhere below, so it seems to me like the silent=yes part for the
> query-migrate execution didn’t work as intended.
>
> (And it does seem to work below, when waiting for a “100 %” to appear on
> $dest.)
>
> It’s been a while since we’ve touched common.qemu, so nothing comes to my
> mind immediately that might have broken this.
...
> I’ve never hit this so far.
>
> The only things to try I can come up with would be to bisect, or to try
> adding `silent=$silent` to the `_timed_wait_for` calls in `send_qemu_cmd`...
Seems also like it does not reproduce that easily, though - I've just seen
it once so far while running "make -j6 check SPEED=slow", so lots of other
stuff was happening at the same time. I'll keep an eye on it to see whether
I can reproduce it more easily somehow.
Thomas
next prev parent reply other threads:[~2022-07-05 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 9:35 Failure in iotest 183 Thomas Huth
2022-07-05 9:58 ` Hanna Reitz
2022-07-05 10:20 ` Thomas Huth [this message]
2022-07-21 9:01 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3efdf6ae-1ace-6db6-e947-e6288c41acd7@redhat.com \
--to=thuth@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).