From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org, Thomas Huth <huth@tuxfamily.org>
Subject: Re: [Qemu-devel] [PATCH for-3.0] boards.h: Remove doc comment reference to nonexistent function
Date: Mon, 9 Jul 2018 15:18:12 +0200 [thread overview]
Message-ID: <3efdfd1a-2f68-f844-a0c1-10f2430309bb@redhat.com> (raw)
In-Reply-To: <20180702130605.13611-1-peter.maydell@linaro.org>
On 02/07/2018 15:06, Peter Maydell wrote:
> commit b08199c6fbea1 accidentally added a reference to a doc
> comment to a nonexistent memory_region_allocate_aux_memory().
> This was a leftover from a previous version of the patchset
> which defined memory_region_allocate_aux_memory() for
> "allocate RAM MemoryRegion and register it for migration"
> and left "memory_region_init_ram()" with its original semantics
> of "allocate RAM MR but do not register for migration". In
> the end we decided on the approach of "memory_region_init_ram()
> registers the MR for migration, and memory_region_init_ram_nomigrate()
> is a new function which does not", but this comment change
> got left in by mistake. Revert that part of the commit.
>
> Reported-by: Thomas Huth <huth@tuxfamily.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Doesn't strictly need to go into 3.0, but it's a trivial
> doc comment fix...
>
> include/hw/boards.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index 79069ddcbec..d139a431a67 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -35,8 +35,7 @@
> *
> * Smaller pieces of memory (display RAM, static RAMs, etc) don't need
> * to be backed via the -mem-path memory backend and can simply
> - * be created via memory_region_allocate_aux_memory() or
> - * memory_region_init_ram().
> + * be created via memory_region_init_ram().
> */
> void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
> const char *name,
>
Sure, it's just a doc fix.
Paolo
prev parent reply other threads:[~2018-07-09 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 13:06 [Qemu-devel] [PATCH for-3.0] boards.h: Remove doc comment reference to nonexistent function Peter Maydell
2018-07-09 13:15 ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2018-07-10 16:46 ` Thomas Huth
2018-07-09 13:18 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3efdfd1a-2f68-f844-a0c1-10f2430309bb@redhat.com \
--to=pbonzini@redhat.com \
--cc=huth@tuxfamily.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).