From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcW3d-0002cB-Ox for qemu-devel@nongnu.org; Mon, 09 Jul 2018 09:18:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcW3Z-0003Vo-2e for qemu-devel@nongnu.org; Mon, 09 Jul 2018 09:18:25 -0400 References: <20180702130605.13611-1-peter.maydell@linaro.org> From: Paolo Bonzini Message-ID: <3efdfd1a-2f68-f844-a0c1-10f2430309bb@redhat.com> Date: Mon, 9 Jul 2018 15:18:12 +0200 MIME-Version: 1.0 In-Reply-To: <20180702130605.13611-1-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-3.0] boards.h: Remove doc comment reference to nonexistent function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: patches@linaro.org, Thomas Huth On 02/07/2018 15:06, Peter Maydell wrote: > commit b08199c6fbea1 accidentally added a reference to a doc > comment to a nonexistent memory_region_allocate_aux_memory(). > This was a leftover from a previous version of the patchset > which defined memory_region_allocate_aux_memory() for > "allocate RAM MemoryRegion and register it for migration" > and left "memory_region_init_ram()" with its original semantics > of "allocate RAM MR but do not register for migration". In > the end we decided on the approach of "memory_region_init_ram() > registers the MR for migration, and memory_region_init_ram_nomigrate() > is a new function which does not", but this comment change > got left in by mistake. Revert that part of the commit. > > Reported-by: Thomas Huth > Signed-off-by: Peter Maydell > --- > Doesn't strictly need to go into 3.0, but it's a trivial > doc comment fix... > > include/hw/boards.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/hw/boards.h b/include/hw/boards.h > index 79069ddcbec..d139a431a67 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h > @@ -35,8 +35,7 @@ > * > * Smaller pieces of memory (display RAM, static RAMs, etc) don't need > * to be backed via the -mem-path memory backend and can simply > - * be created via memory_region_allocate_aux_memory() or > - * memory_region_init_ram(). > + * be created via memory_region_init_ram(). > */ > void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner, > const char *name, > Sure, it's just a doc fix. Paolo