Re: [PATCH 3/3] qom: Simplify and merge pointer property getters/setters

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1208 bytes --]

On 10/9/20 2:15 PM, Eduardo Habkost wrote:
> Both the property getter and setter for pointer properties can
> simply call the visitor functions directly, instead of making
> extra copies and requiring additional logic.
> 
> Remove the extra copying logic, and merge the getter and setter
> functions in object_visit_uint*_ptr() accessors.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  qom/object.c | 114 ++++++++++-----------------------------------------
>  1 file changed, 22 insertions(+), 92 deletions(-)
> 
> diff --git a/qom/object.c b/qom/object.c
> index 6b4dfc279a..3b343fd118 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -2496,119 +2496,57 @@ static void *pointer_property_get_ptr(Object *obj, PointerProperty *prop)
>      }
>  }
>  
> -static void property_get_uint8_ptr(Object *obj, Visitor *v, const char *name,
> +static void property_visit_uint8_ptr(Object *obj, Visitor *v, const char *name,
>                                     void *opaque, Error **errp)

Indentation is now off.  Several instances.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]