qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] hw/core/ptimer: Support ptimer being disabled by timer callback
Date: Mon, 26 Oct 2020 22:45:19 +0100	[thread overview]
Message-ID: <3f0c605d-0aea-a7ea-a3da-4db09759527d@redhat.com> (raw)
In-Reply-To: <20201015151829.14656-2-peter.maydell@linaro.org>

On 10/15/20 5:18 PM, Peter Maydell wrote:
> In ptimer_reload(), we call the callback function provided by the
> timer device that is using the ptimer.  This callback might disable
> the ptimer.  The code mostly handles this correctly, except that
> we'll still print the warning about "Timer with delta zero,
> disabling" if the now-disabled timer happened to be set such that it
> would fire again immediately if it were enabled (eg because the
> limit/reload value is zero).
> 
> Suppress the spurious warning message and the unnecessary
> repeat-deletion of the underlying timer in this case.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   hw/core/ptimer.c | 4 ++++
>   1 file changed, 4 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



  reply	other threads:[~2020-10-26 22:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 15:18 [PATCH 0/2] armv7m_systick: Rewrite to use ptimers Peter Maydell
2020-10-15 15:18 ` [PATCH 1/2] hw/core/ptimer: Support ptimer being disabled by timer callback Peter Maydell
2020-10-26 21:45   ` Philippe Mathieu-Daudé [this message]
2020-10-15 15:18 ` [PATCH 2/2] hw/timer/armv7m_systick: Rewrite to use ptimers Peter Maydell
2020-10-15 15:31   ` Peter Maydell
2020-10-26 21:57     ` Philippe Mathieu-Daudé
2020-10-26 20:42 ` [PATCH 0/2] armv7m_systick: " Peter Maydell
2020-10-26 20:54   ` 罗勇刚(Yonggang Luo)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f0c605d-0aea-a7ea-a3da-4db09759527d@redhat.com \
    --to=philmd@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).