From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVLjD-00022u-UA for qemu-devel@nongnu.org; Tue, 19 Jun 2018 14:51:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVLjD-00039C-6v for qemu-devel@nongnu.org; Tue, 19 Jun 2018 14:51:44 -0400 References: <20180426025129.621969-1-eblake@redhat.com> <20180426025129.621969-6-eblake@redhat.com> From: Eric Blake Message-ID: <3f211a15-a7e6-c062-8ac8-4aaeedcd7715@redhat.com> Date: Tue, 19 Jun 2018 13:51:36 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 5/6] iotests: Add new test 214 for max compressed cluster offset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, qemu-block@nongnu.org On 04/26/2018 07:10 AM, Alberto Garcia wrote: > On Thu 26 Apr 2018 04:51:28 AM CEST, Eric Blake wrote: >> If you have a capable file system (tmpfs is good, ext4 not so much; >> run ./check with TEST_DIR pointing to a good location so as not >> to skip the test), it's actually possible to create a qcow2 file >> that expands to a sparse 512T image with just over 38M of content. >> The test is not the world's fastest (qemu crawling through 256M >> bits of refcount table to find the next cluster to allocate takes >> several seconds, as does qemu-img check reporting millions of >> leaked clusters); but it DOES catch the problem that the previous >> patch just fixed where writing a compressed cluster to a full >> image ended up overwriting the wrong cluster. >> >> Suggested-by: Max Reitz >> Signed-off-by: Eric Blake > > Nice test :-) > > Reviewed-by: Alberto Garcia 214 is already in the tree in the meantime; this will need a rebase to pick the next available test number (220 might be claimed, so 222?) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org