From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB88CC2D0CD for ; Wed, 21 May 2025 13:13:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uHjFU-0003uj-6p; Wed, 21 May 2025 09:12:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHjFR-0003uN-Lz for qemu-devel@nongnu.org; Wed, 21 May 2025 09:12:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uHjFP-0000Ah-RC for qemu-devel@nongnu.org; Wed, 21 May 2025 09:12:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747833155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Fmua6SHYTWsBx5orUkrWfyyWS4olUgPpRhndNXxOKVg=; b=akjgN3dTZV6oO7KpgNwneGqkUzPX0KRqkd5x15V9VOACJ65iBwr94KyFhGmemPTTA/N3Qv OCAMNyma4VFw98AJgiG8qFpjcc+JUV6wDEV5mGGp6BI9gKzpkSBLR4JRb9OoTMQdEaMPjE qTKqkfHnRY/GqZ6DWPMj/wNm6wSfI2o= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-375-0sT9y1b8Ou2oIko0oZdpvw-1; Wed, 21 May 2025 09:12:34 -0400 X-MC-Unique: 0sT9y1b8Ou2oIko0oZdpvw-1 X-Mimecast-MFC-AGG-ID: 0sT9y1b8Ou2oIko0oZdpvw_1747833153 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-442d472cf7fso53859645e9.3 for ; Wed, 21 May 2025 06:12:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747833153; x=1748437953; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Fmua6SHYTWsBx5orUkrWfyyWS4olUgPpRhndNXxOKVg=; b=uLFxzLi5TRJyeGESNcCsA+QuRYVZhGTnLDwwCJCGuNJLMjzFZX1RfbG978bPZoDy2P uj1M9rF9E2vTQw7Ii+3LdpZQTubGL6KtdX+utz7xH5vZp/7NOPlnIFdc5zH5EmPpwjge Xvc3SlrZVuVVmqwZL38PPfbQE5XbHGLzEg10/qBWo5AQqJeWIqcgslxMvWj9TzjXa9lQ xkZfUi4ljqpR8/LLw4ppaoCnb2IwsYDDCkWYUwsbQHzSapvbVEF+Rrb31BYieUiINNYK nQRlZLbyLbH2gf1HnqIkH+Cu4Ug0Ymz1XWpkjsVQ+8xuGiSXQozFFMW9RUtShkojnP90 Bp9A== X-Forwarded-Encrypted: i=1; AJvYcCVzz5xAn3b6t7xJen4l+NwnJaNZZ78i/VRcU0JuVYCofTSqXJgVsM0ihs0I7fwmXvfd4a58Pycu9GTv@nongnu.org X-Gm-Message-State: AOJu0Yz9G2NcjXLuPZp9FzZ49W2SbeufZL4fukE3TxZOAMJj2cm8C+52 +75Vnmy5I5oEoe9085JySskjF9A5J286cq+rN+w5z+lCzu0KU540dWbDGfTPcBHuq6n6T4BZfpv xCf4I2sW8PWR6t2pJQkFsgh6HJKYoQbXgAJ8+AIItnL+lMWoIzxRwzHdT X-Gm-Gg: ASbGncvT4relsbEgk5o+OlclK9pKM6jGfyNtCUKbv1ELp3cwz245Jz7ki9kGml9tvdy Z1UGJvlcc579bCU4jNPUF+EEa0guvha3KTqjW56I++VYyoXak9Mh0dZIeh5QxFEwreqonLKCvJ0 bc8JbL51nr77YutxOb86j5BtWztv7fOvQWS3/d3lXzrw62jvpnRDW8wRuIakCuulrzFv00c6oB6 AKPkAoDbE1mEj65gTMB+R/EapqReaS8xN73RZUKgjrqfB/zriTfnU9u+P+psW2vPjLGhqS+4iIy YO9boJ5xBoDz6N3MtGVgfLisZxcG7WvkN41eMLMa0qkPLk9D0Q== X-Received: by 2002:a05:600c:384b:b0:43c:f8fc:f6a6 with SMTP id 5b1f17b1804b1-442fd6100famr188925735e9.9.1747833152876; Wed, 21 May 2025 06:12:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHoLhxHcw3gv9wMIfSCyox08Ir1DZTe6nXc9iO2B12zsSp9oUVRda9oUK0S4iaNaD8mzWL+Pg== X-Received: by 2002:a05:600c:384b:b0:43c:f8fc:f6a6 with SMTP id 5b1f17b1804b1-442fd6100famr188925425e9.9.1747833152551; Wed, 21 May 2025 06:12:32 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:3f78:514a:4f03:fdc0? ([2a01:e0a:280:24f0:3f78:514a:4f03:fdc0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f6f05581sm69180505e9.13.2025.05.21.06.12.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 May 2025 06:12:32 -0700 (PDT) Message-ID: <3f22f6be-0683-43ac-b515-dc6c608972ec@redhat.com> Date: Wed, 21 May 2025 15:12:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] vfio/iommufd: Add comment emphasizing no movement of hiod->realize() call To: Zhenzhong Duan , qemu-devel@nongnu.org Cc: alex.williamson@redhat.com, chao.p.peng@intel.com References: <20250521110301.3313877-1-zhenzhong.duan@intel.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20250521110301.3313877-1-zhenzhong.duan@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.184, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 5/21/25 13:03, Zhenzhong Duan wrote: > The nested IOMMU support needs device and hwpt id which are generated > only after attachment. Hiod encapsulates these information in realize() > and passes to vIOMMU. > > Suggested-by: Cédric Le Goater > Signed-off-by: Zhenzhong Duan Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/vfio/iommufd.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/vfio/iommufd.c b/hw/vfio/iommufd.c > index af1c7ab10a..6b2696793f 100644 > --- a/hw/vfio/iommufd.c > +++ b/hw/vfio/iommufd.c > @@ -592,6 +592,10 @@ found_container: > goto err_listener_register; > } > > + /* > + * Do not move this code before attachment! The nested IOMMU support > + * needs device and hwpt id which are generated only after attachment. > + */ > if (!vfio_device_hiod_create_and_realize(vbasedev, > TYPE_HOST_IOMMU_DEVICE_IOMMUFD_VFIO, errp)) { > goto err_listener_register;