From: Paolo Bonzini <pbonzini@redhat.com>
To: Mario Smarduch <msmarduch@digitalocean.com>,
philmd@redhat.com, mtosatti@redhat.com, armbru@redhat.com
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
ehabkost@redhat.com, rth@twiddle.net
Subject: Re: [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options
Date: Wed, 9 Oct 2019 23:16:50 +0200 [thread overview]
Message-ID: <3f24a34d-de91-c996-ffd8-306d0e0ce6a0@redhat.com> (raw)
In-Reply-To: <20191009164459.8209-2-msmarduch@digitalocean.com>
On 09/10/19 18:44, Mario Smarduch wrote:
> };
> @@ -1263,6 +1267,7 @@ static void realtime_init(void)
> static void configure_msg(QemuOpts *opts)
> {
> enable_timestamp_msg = qemu_opt_get_bool(opts, "timestamp", true);
> + enable_guestname_msg = qemu_opt_get_bool(opts, "name", false);
> }
Before, the msg option certainly had a timestamp suboption, but this
might not be the case now. So that "true" needs to become "false".
I'll fix it up when applying.
Paolo
next prev parent reply other threads:[~2019-10-09 21:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 16:44 [PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs Mario Smarduch
2019-10-09 16:44 ` [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options Mario Smarduch
2019-10-09 21:16 ` Paolo Bonzini [this message]
2019-10-10 7:02 ` Markus Armbruster
2019-10-10 8:16 ` Markus Armbruster
2019-10-10 11:25 ` Paolo Bonzini
2019-10-09 16:44 ` [PATCHv2 2/2] target/i386: log MCE guest and host addresses Mario Smarduch
2019-10-09 21:19 ` [PATCHv2 0/2] log guest name and memory error type AO, AR for MCEs Paolo Bonzini
2019-10-09 23:01 ` Mario Smarduch
2019-10-09 22:55 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f24a34d-de91-c996-ffd8-306d0e0ce6a0@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=msmarduch@digitalocean.com \
--cc=mtosatti@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).