From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org,
qemu-stable@nongnu.org
Subject: Re: [PATCH for-4.2 0/2] Fix bitmap migration
Date: Tue, 26 Nov 2019 11:31:52 +0100 [thread overview]
Message-ID: <3f25f814-24be-cc3d-770a-8ad9d3be5993@redhat.com> (raw)
In-Reply-To: <20191125125229.13531-1-vsementsov@virtuozzo.com>
[-- Attachment #1.1: Type: text/plain, Size: 972 bytes --]
On 25.11.19 13:52, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> We've faced a bug in rhev-2.12.0-33.el7-based Qemu.
> In upstream, bug introduced in 4.0 by 74da6b943565c45
> "block/dirty-bitmaps: implement inconsistent bit" commit.
> At this commit we started to load inconsistent bitmap instead of
> silently ignoring them, and it now I see that it breaks migration.
>
> The fix is very simple, so I think it's OK for 4.2.. Still, it's not a
> degradation, so we may postpone it to 5.0.
>
> Vladimir Sementsov-Ogievskiy (2):
> block/qcow2-bitmap: fix bitmap migration
> iotests: add new test cases to bitmap migration
>
> block/qcow2-bitmap.c | 21 ++++++++++++++++++++-
> tests/qemu-iotests/169 | 22 +++++++++++++++-------
> tests/qemu-iotests/169.out | 4 ++--
> 3 files changed, 37 insertions(+), 10 deletions(-)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-11-26 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 12:52 [PATCH for-4.2 0/2] Fix bitmap migration Vladimir Sementsov-Ogievskiy
2019-11-25 12:52 ` [PATCH 1/2] block/qcow2-bitmap: fix " Vladimir Sementsov-Ogievskiy
2019-11-25 12:52 ` [PATCH 2/2] iotests: add new test cases to " Vladimir Sementsov-Ogievskiy
2019-11-25 13:50 ` [PATCH for-4.2 0/2] Fix " Max Reitz
2019-11-25 14:04 ` Vladimir Sementsov-Ogievskiy
2019-11-26 10:31 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f25f814-24be-cc3d-770a-8ad9d3be5993@redhat.com \
--to=mreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).