[Qemu-devel] [PATCH v2] trivial fix of malloc to g_new in thunk

[Qemu-devel] [PATCH v2] trivial fix of malloc to g_new in thunk

[Aarushi Mehta]

Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
---
Note that since thunking occurs throughout the lifetime of the QEMU instance, 
there is no matching 'free' to correct
It might be valuable to edit the BiteSizedTasks to reflect that g_new is favoured over g_malloc

 thunk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/thunk.c b/thunk.c
index d5d8645cd4..17f3d320bb 100644
--- a/thunk.c
+++ b/thunk.c
@@ -89,7 +89,7 @@ void thunk_register_struct(int id, const char *name, const argtype *types)
     for(i = 0;i < 2; i++) {
         offset = 0;
         max_align = 1;
-        se->field_offsets[i] = malloc(nb_fields * sizeof(int));
+        se->field_offsets[i] = g_new(int, nb_fields);
         type_ptr = se->field_types;
         for(j = 0;j < nb_fields; j++) {
             size = thunk_type_size(type_ptr, i);
-- 
2.17.1
Regards
Aarushi Mehta

Re: [Qemu-devel] [PATCH v2] trivial fix of malloc to g_new in thunk

[Eric Blake]

On 2/28/19 9:35 AM, Aarushi Mehta wrote:
> 
> Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
> ---
> Note that since thunking occurs throughout the lifetime of the QEMU instance, 
> there is no matching 'free' to correct

This sentence is vital to the patch, so it belongs above the --- and
S-o-b as part of the commit message.

> It might be valuable to edit the BiteSizedTasks to reflect that g_new is favoured over g_malloc

And I've done that now, by emphasizing the discussion in HACKING (rather
than repeating it on the wiki):
https://wiki.qemu.org/index.php?title=Contribute/BiteSizedTasks&diff=8247&oldid=8242

With the improved commit message,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org