From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>,
Riku Voipio <riku.voipio@iki.fi>,
Eduardo Habkost <ehabkost@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] target/i386: Fix OUTL debug output
Date: Thu, 21 May 2020 16:06:45 +0200 [thread overview]
Message-ID: <3f4fc712-5021-e4dd-03e6-f3490a1785e6@redhat.com> (raw)
In-Reply-To: <d4f069cd-6357-480a-3732-71e97d0e9aea@amsat.org>
On 19/05/20 14:23, Philippe Mathieu-Daudé wrote:
> On 5/19/20 5:39 AM, Richard Henderson wrote:
>> On 5/17/20 4:01 AM, Philippe Mathieu-Daudé wrote:
>>> Fix OUTL instructions incorrectly displayed as OUTW.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> target/i386/misc_helper.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>>
>> as far as it goes. We should of course never be printing to stderr, but
>> logging or tracing.
>
> Yes, this is what the cpu_io() functions do in ioport.c, but they use
> MEMTXATTRS_UNSPECIFIED.
>
> If we could replace one with another, I'm not sure which one is the
> correct one.
>
> Maybe keep cpu_io() from ioport.c but add a MemTxAttrs argument?
>
> Regards,
>
> Phil.
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-05-21 14:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 11:01 [PATCH] target/i386: Fix OUTL debug output Philippe Mathieu-Daudé
2020-05-19 3:39 ` Richard Henderson
2020-05-19 12:23 ` Philippe Mathieu-Daudé
2020-05-21 14:06 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f4fc712-5021-e4dd-03e6-f3490a1785e6@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).