qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>,
	Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org,
	qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] timer: fix misleading comment in timer.h
Date: Thu, 1 Dec 2016 16:23:17 +0100	[thread overview]
Message-ID: <3f5cd5b4-7b4f-ceb9-6e62-8c21d156daff@redhat.com> (raw)
In-Reply-To: <20161201135008.GK10441@stefanha-x1.localdomain>



On 01/12/2016 14:50, Stefan Hajnoczi wrote:
> On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote:
>> It's timer to expire, not clock.
>>
>> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
>> ---
>>  include/qemu/timer.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> For the whole series:
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> PS: I suggest sending a cover letter "[PATCH 0/3]" in the future.  This
> makes it easy for reviewers to indicate they have reviewed the whole
> series.  Without a cover letter it's ambiguous whether my single
> Reviewed-by: applies to just this patch or to the whole series - and
> patch management tools will probably get it wrong too.
> 

I've queued the series for QEMU 2.9.  This kind of patch can probably be
sent to qemu-trivial@nongnu.org, which will simplify their inclusion.

Of course, this is not meant to diminish your contribution!  "Trivial"
patches are important and good comments will also help the next person
studying QEMU's source code.

Thanks,

Paolo

  reply	other threads:[~2016-12-01 15:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01  4:30 [Qemu-devel] [PATCH 1/3] timer: fix misleading comment in timer.h Yaowei Bai
2016-12-01  4:30 ` [Qemu-devel] [PATCH 2/3] main-loop: update comment for qemu_mutex_lock/unlock_iothread Yaowei Bai
2016-12-01  4:30 ` [Qemu-devel] [PATCH 3/3] block: drop remaining legacy aio functions in comment Yaowei Bai
2016-12-01 13:50 ` [Qemu-devel] [PATCH 1/3] timer: fix misleading comment in timer.h Stefan Hajnoczi
2016-12-01 15:23   ` Paolo Bonzini [this message]
2016-12-05  3:08     ` Yaowei Bai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f5cd5b4-7b4f-ceb9-6e62-8c21d156daff@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=baiyaowei@cmss.chinamobile.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).