From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54D8CC433F5 for ; Wed, 22 Sep 2021 17:26:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E768F610D1 for ; Wed, 22 Sep 2021 17:26:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E768F610D1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen0n.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:54220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT60o-0000ZI-5H for qemu-devel@archiver.kernel.org; Wed, 22 Sep 2021 13:26:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT5y2-0006Fl-JU for qemu-devel@nongnu.org; Wed, 22 Sep 2021 13:23:35 -0400 Received: from [115.28.160.31] (port=39750 helo=mailbox.box.xen0n.name) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT5y1-0001Pu-0Z for qemu-devel@nongnu.org; Wed, 22 Sep 2021 13:23:34 -0400 Received: from [192.168.9.172] (unknown [101.88.29.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 928B6633F2; Thu, 23 Sep 2021 01:23:28 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=xen0n.name; s=mail; t=1632331408; bh=jKsJ80w75FefNPHD6jfIE12QntCbueYaRtpESoKYS7s=; h=Date:Subject:To:References:From:In-Reply-To:From; b=tQRNsTlphSh9bt/zcA0oGG13Ylmh5eqmD+8JW+og3MQGqG6mPwQ9vgZY0/crdZDmv 4EM/dXgM9WlaDJro4eU8reqbv1wlZ9/urI+Jy8siWjAEgqeUzzaOyUE3OLWu5Dn8fd T0bH5qf4AFkReyGKGnHjlhQKr32CcWpK34OYjqZM= Message-ID: <3f5d0a19-ba9a-8328-f8f0-229a96597c87@xen0n.name> Date: Thu, 23 Sep 2021 01:23:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0a1 Subject: Re: [PATCH v2 12/30] tcg/loongarch64: Implement not/and/or/xor/nor/andc/orc/eqv ops Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org References: <20210921201915.601245-1-git@xen0n.name> <20210921201915.601245-13-git@xen0n.name> <90820738-c1f4-398c-308d-ec89be2d985f@linaro.org> From: WANG Xuerui In-Reply-To: <90820738-c1f4-398c-308d-ec89be2d985f@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 115.28.160.31 (failed) Received-SPF: pass client-ip=115.28.160.31; envelope-from=i.qemu@xen0n.name; helo=mailbox.box.xen0n.name X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Richard, On 9/22/21 12:35, Richard Henderson wrote: > On 9/21/21 1:18 PM, WANG Xuerui wrote: >> +    case INDEX_op_eqv_i32: >> +    case INDEX_op_eqv_i64: >> +        if (c2) { >> +            /* guaranteed to fit due to constraint */ >> +            tcg_out_opc_xori(s, a0, a1, ~a2); >> +        } else { >> +            tcg_out_opc_nor(s, a0, a2, TCG_REG_ZERO); >> +            tcg_out_opc_xor(s, a0, a1, a0); >> +        } >> +        break; > > You don't actually have eqv (xnor), so don't pretend that you do. The > middle-end will expand this as xor + not on its own. Sure; I'll remove support for eqv in v3. > > Otherwise, > Reviewed-by: Richard Henderson > > > r~