From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDape-000550-TC for qemu-devel@nongnu.org; Mon, 08 Apr 2019 16:25:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDapd-0003xn-RD for qemu-devel@nongnu.org; Mon, 08 Apr 2019 16:25:30 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58118 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDapd-0003rE-EF for qemu-devel@nongnu.org; Mon, 08 Apr 2019 16:25:29 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x38KEPjZ126921 for ; Mon, 8 Apr 2019 16:25:17 -0400 Received: from e15.ny.us.ibm.com (e15.ny.us.ibm.com [129.33.205.205]) by mx0b-001b2d01.pphosted.com with ESMTP id 2rrd3freuw-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 08 Apr 2019 16:25:16 -0400 Received: from localhost by e15.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 8 Apr 2019 21:25:16 +0100 References: <20190301093902.27799-1-cohuck@redhat.com> <20190301093902.27799-2-cohuck@redhat.com> <9e81af36-ebd2-671b-5256-90e8efaad6f2@linux.ibm.com> <20190408190747.12e3618b.cohuck@redhat.com> From: Eric Farman Date: Mon, 8 Apr 2019 16:25:11 -0400 MIME-Version: 1.0 In-Reply-To: <20190408190747.12e3618b.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: <3f64d56f-e27a-3f95-6c44-2602dc00ea0f@linux.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Farhan Ali Cc: Halil Pasic , Pierre Morel , linux-s390@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, qemu-s390x@nongnu.org, Alex Williamson On 4/8/19 1:07 PM, Cornelia Huck wrote: > On Mon, 8 Apr 2019 13:02:12 -0400 > Farhan Ali wrote: > >> On 03/01/2019 04:38 AM, Cornelia Huck wrote: >>> When we get a solicited interrupt, the start function may have >>> been cleared by a csch, but we still have a channel program >>> structure allocated. Make it safe to call the cp accessors in >>> any case, so we can call them unconditionally. >>> >>> While at it, also make sure that functions called from other parts >>> of the code return gracefully if the channel program structure >>> has not been initialized (even though that is a bug in the caller). >>> >>> Reviewed-by: Eric Farman >>> Signed-off-by: Cornelia Huck >>> --- >> >> Hi Connie, >> >> My series of fixes for vfio-ccw depends on this patch as I would like to >> call cp_free unconditionally :) (I had developed my code on top of your >> patches). >> >> Could we pick this patch up as well when/if you pick up my patch series? >> I am in the process of sending out a v2. >> >> Regarding this patch we could merge it as a stand alone patch, separate >> from this series. And also the patch LGTM >> >> Reviewed-by: Farhan Ali > > Actually, I wanted to ask how people felt about merging this whole > series for the next release :) It would be one thing less on my plate... > I'm not opposed to it. Every time I try to review patches 4 and 6 I get an asynchronous interrupt of my own. :) I'll at least get you an ack in the next day or two. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C027C10F13 for ; Mon, 8 Apr 2019 20:26:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD80E21841 for ; Mon, 8 Apr 2019 20:26:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD80E21841 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:58527 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDaqS-0005Uj-Ou for qemu-devel@archiver.kernel.org; Mon, 08 Apr 2019 16:26:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDape-000550-TC for qemu-devel@nongnu.org; Mon, 08 Apr 2019 16:25:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDapd-0003xn-RD for qemu-devel@nongnu.org; Mon, 08 Apr 2019 16:25:30 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58118 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDapd-0003rE-EF for qemu-devel@nongnu.org; Mon, 08 Apr 2019 16:25:29 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x38KEPjZ126921 for ; Mon, 8 Apr 2019 16:25:17 -0400 Received: from e15.ny.us.ibm.com (e15.ny.us.ibm.com [129.33.205.205]) by mx0b-001b2d01.pphosted.com with ESMTP id 2rrd3freuw-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 08 Apr 2019 16:25:16 -0400 Received: from localhost by e15.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 8 Apr 2019 21:25:16 +0100 Received: from b01cxnp22034.gho.pok.ibm.com (9.57.198.24) by e15.ny.us.ibm.com (146.89.104.202) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 8 Apr 2019 21:25:13 +0100 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x38KPCZF13762694 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 8 Apr 2019 20:25:12 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4D5C82805E; Mon, 8 Apr 2019 20:25:12 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0B85528059; Mon, 8 Apr 2019 20:25:11 +0000 (GMT) Received: from [9.60.85.4] (unknown [9.60.85.4]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 8 Apr 2019 20:25:11 +0000 (GMT) To: Cornelia Huck , Farhan Ali References: <20190301093902.27799-1-cohuck@redhat.com> <20190301093902.27799-2-cohuck@redhat.com> <9e81af36-ebd2-671b-5256-90e8efaad6f2@linux.ibm.com> <20190408190747.12e3618b.cohuck@redhat.com> From: Eric Farman Date: Mon, 8 Apr 2019 16:25:11 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190408190747.12e3618b.cohuck@redhat.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19040820-0068-0000-0000-000003B243C8 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010891; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000284; SDB=6.01186258; UDB=6.00621275; IPR=6.00967015; MB=3.00026348; MTD=3.00000008; XFM=3.00000015; UTC=2019-04-08 20:25:15 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19040820-0069-0000-0000-000048166EE5 Message-Id: <3f64d56f-e27a-3f95-6c44-2602dc00ea0f@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-08_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=589 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904080152 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.158.5 Subject: Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, Alex Williamson , Pierre Morel , kvm@vger.kernel.org, qemu-devel@nongnu.org, Halil Pasic , qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190408202511.Uavc7Z_nvDxPmt9MS6PlNOVlrgdvsaBLRchTxDQtONk@z> On 4/8/19 1:07 PM, Cornelia Huck wrote: > On Mon, 8 Apr 2019 13:02:12 -0400 > Farhan Ali wrote: > >> On 03/01/2019 04:38 AM, Cornelia Huck wrote: >>> When we get a solicited interrupt, the start function may have >>> been cleared by a csch, but we still have a channel program >>> structure allocated. Make it safe to call the cp accessors in >>> any case, so we can call them unconditionally. >>> >>> While at it, also make sure that functions called from other parts >>> of the code return gracefully if the channel program structure >>> has not been initialized (even though that is a bug in the caller). >>> >>> Reviewed-by: Eric Farman >>> Signed-off-by: Cornelia Huck >>> --- >> >> Hi Connie, >> >> My series of fixes for vfio-ccw depends on this patch as I would like to >> call cp_free unconditionally :) (I had developed my code on top of your >> patches). >> >> Could we pick this patch up as well when/if you pick up my patch series? >> I am in the process of sending out a v2. >> >> Regarding this patch we could merge it as a stand alone patch, separate >> from this series. And also the patch LGTM >> >> Reviewed-by: Farhan Ali > > Actually, I wanted to ask how people felt about merging this whole > series for the next release :) It would be one thing less on my plate... > I'm not opposed to it. Every time I try to review patches 4 and 6 I get an asynchronous interrupt of my own. :) I'll at least get you an ack in the next day or two.