From: David Hildenbrand <david@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
jasowang@redhat.com, mst@redhat.com,
"Paolo Bonzini" <pbonzini@redhat.com>,
marcandre.lureau@redhat.com, eric.auger@redhat.com,
"Peter Xu" <peterx@redhat.com>
Subject: Re: [PATCH 2/2] tpm_crb: mark memory as protected
Date: Thu, 22 Jun 2023 15:05:33 +0200 [thread overview]
Message-ID: <3f65e040-9ff8-2d40-299a-2d9d30ada58e@redhat.com> (raw)
In-Reply-To: <06d07da8-68a7-c7da-1a78-f45750971ede@redhat.com>
On 22.06.23 14:59, Laurent Vivier wrote:
> On 6/21/23 11:13, David Hildenbrand wrote:
>> On 20.06.23 21:50, Laurent Vivier wrote:
>>> This memory is not correctly aligned and cannot be registered
>>> by vDPA and VFIO.
>>>
>>> An error is reported for vhost-vdpa case:
>>> qemu-kvm: vhost_vdpa_listener_region_add received unaligned region
>>>
>>> To make it ignored by VFIO and vDPA devices, mark it as RAM_PROTECTED.
>>
>> So, VFIO will simply skip these sections via vfio_listener_valid_section() I guess.
>>
>> Yes, it will report an error but it will happily continue.
>>
>> So regarding vDPA, we're also only concerned about removing the reported error, everything
>> else works as expected?
>>
>
> Yes, it has been tested and vDPA works as expected.
Okay, so no Fixes: tags required
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-06-22 13:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 19:50 [PATCH 0/2] vhost-vdpa: skip TPM CRB memory section Laurent Vivier
2023-06-20 19:50 ` [PATCH 1/2] memory: introduce memory_region_init_ram_protected() Laurent Vivier
2023-06-21 12:27 ` Stefan Berger
2023-06-22 13:05 ` David Hildenbrand
2023-06-22 13:16 ` Peter Maydell
2023-06-20 19:50 ` [PATCH 2/2] tpm_crb: mark memory as protected Laurent Vivier
2023-06-21 9:13 ` David Hildenbrand
2023-06-22 12:59 ` Laurent Vivier
2023-06-22 13:05 ` David Hildenbrand [this message]
2023-06-21 12:29 ` Stefan Berger
2023-06-22 13:05 ` David Hildenbrand
2023-06-22 13:12 ` Peter Maydell
2023-06-22 13:39 ` Laurent Vivier
2023-06-22 13:53 ` Peter Maydell
2023-07-04 3:07 ` Jason Wang
2023-07-04 6:45 ` Laurent Vivier
2023-06-21 15:32 ` [PATCH 0/2] vhost-vdpa: skip TPM CRB memory section Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f65e040-9ff8-2d40-299a-2d9d30ada58e@redhat.com \
--to=david@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jasowang@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).