qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, pl@kamp.de, qemu-stable@nongnu.org,
	qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.8 0/2] pass partial discard requests all the way down
Date: Fri, 11 Nov 2016 08:15:52 -0600	[thread overview]
Message-ID: <3f7a574d-0953-dccc-c571-16e69f59ce4a@redhat.com> (raw)
In-Reply-To: <c90c2586-ade4-5ba8-a555-f9c4ba4d1fd9@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

On 11/11/2016 04:11 AM, Laszlo Ersek wrote:
> On 11/11/16 11:09, Laszlo Ersek wrote:
>> On 11/11/16 00:10, Eric Blake wrote:
>>> Peter reported a mild regression in qemu 2.7 when targetting the
>>> Dell Equallogic iSCSI, which advertizes a preferred and maximum
>>> unmap alignment at 15M.  In qemu 2.6, trims not aligned to those
>>> boundaries still made it to the device, but in 2.7, the block
>>> layer is ignoring unaligned portions of guest requests, resulting
>>> in fewer blocks being actually trimmed.
>>>
>>> Since discard is advisary,
>>
>> advisory?
> 
> Ehh, sorry, I missed that this msg wouldn't be committed; it's just the
> blurb for the series. The actual commits and the code have the right
> spelling. Not gratuitously trying to be a smart-ass...

On the other hand, it's not every day you get to call me out on a typo,
so have fun doing it :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

      reply	other threads:[~2016-11-11 14:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10 23:10 [Qemu-devel] [PATCH for-2.8 0/2] pass partial discard requests all the way down Eric Blake
2016-11-10 23:10 ` [Qemu-devel] [PATCH 1/2] block: Return -ENOTSUP rather than assert on unaligned discards Eric Blake
2016-11-10 23:10 ` [Qemu-devel] [PATCH 2/2] block: Pass unaligned discard requests to drivers Eric Blake
2016-11-11 10:58   ` [Qemu-devel] [Qemu-stable] " Peter Lieven
2016-11-11 14:22     ` Eric Blake
2016-11-11 10:09 ` [Qemu-devel] [PATCH for-2.8 0/2] pass partial discard requests all the way down Laszlo Ersek
2016-11-11 10:11   ` Laszlo Ersek
2016-11-11 14:15     ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f7a574d-0953-dccc-c571-16e69f59ce4a@redhat.com \
    --to=eblake@redhat.com \
    --cc=lersek@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).