Re: [Qemu-devel] [PATCH for-2.8 0/2] pass partial discard requests all the way down

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

On 11/11/2016 04:11 AM, Laszlo Ersek wrote:
> On 11/11/16 11:09, Laszlo Ersek wrote:
>> On 11/11/16 00:10, Eric Blake wrote:
>>> Peter reported a mild regression in qemu 2.7 when targetting the
>>> Dell Equallogic iSCSI, which advertizes a preferred and maximum
>>> unmap alignment at 15M.  In qemu 2.6, trims not aligned to those
>>> boundaries still made it to the device, but in 2.7, the block
>>> layer is ignoring unaligned portions of guest requests, resulting
>>> in fewer blocks being actually trimmed.
>>>
>>> Since discard is advisary,
>>
>> advisory?
> 
> Ehh, sorry, I missed that this msg wouldn't be committed; it's just the
> blurb for the series. The actual commits and the code have the right
> spelling. Not gratuitously trying to be a smart-ass...

On the other hand, it's not every day you get to call me out on a typo,
so have fun doing it :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]