From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnSW1-0003sk-Hn for qemu-devel@nongnu.org; Fri, 23 Sep 2016 11:35:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnSW0-0006H9-AG for qemu-devel@nongnu.org; Fri, 23 Sep 2016 11:35:53 -0400 References: <1474595152-4383-1-git-send-email-jsnow@redhat.com> From: Max Reitz Message-ID: <3f7aa705-f78e-c14d-0de5-61cdd867a8c2@redhat.com> Date: Fri, 23 Sep 2016 17:35:40 +0200 MIME-Version: 1.0 In-Reply-To: <1474595152-4383-1-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ge6QqaDnVmJ0IGWciWkwUXI5VuhDRcqbn" Subject: Re: [Qemu-devel] [PATCH v5 0/3] block: allow flush on devices with open tray List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ge6QqaDnVmJ0IGWciWkwUXI5VuhDRcqbn From: Max Reitz To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org Message-ID: <3f7aa705-f78e-c14d-0de5-61cdd867a8c2@redhat.com> Subject: Re: [PATCH v5 0/3] block: allow flush on devices with open tray References: <1474595152-4383-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1474595152-4383-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 23.09.2016 03:45, John Snow wrote: > When I said "Final re-send," I was lying. Here's a v5. > The title is also a misnomer by now :) >=20 > The move to blk_flush altered the behavior of migration and flushing > nodes that are not reachable via the guest, but are still reachable > via QEMU and may or may not need to be flushed. >=20 > This is intended for 2.6.2 and/or 2.7.1, to fix problems with libvirt > et al being unable to migrate QEMU when the CDROM tray is open. >=20 > v5: > Fix bracket spacing in patch 1. By one space. :( > Added third patch to remove blk_flush_all. >=20 > v4: > Commit message update. >=20 > v3: > Reworking approach and reinstating bdrv_flush_all at Kevin's suggestio= n. >=20 > _______________________________________________________________________= _________ >=20 > For convenience, this branch is available at: > https://github.com/jnsnow/qemu.git branch atapi-tray-migfix > https://github.com/jnsnow/qemu/tree/atapi-tray-migfix >=20 > This version is tagged atapi-tray-migfix-v5: > https://github.com/jnsnow/qemu/releases/tag/atapi-tray-migfix-v5 >=20 > John Snow (3): > block: reintroduce bdrv_flush_all > qemu: use bdrv_flush_all for vm_stop et al > block-backend: remove blk_flush_all >=20 > block/block-backend.c | 22 ---------------------- > block/io.c | 25 +++++++++++++++++++++++++ > cpus.c | 4 ++-- > hw/i386/xen/xen_platform.c | 2 -- > hw/ide/piix.c | 4 ++++ > include/block/block.h | 1 + > include/sysemu/block-backend.h | 1 - > 7 files changed, 32 insertions(+), 27 deletions(-) Reviewed-by: Max Reitz --ge6QqaDnVmJ0IGWciWkwUXI5VuhDRcqbn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEvBAEBCAAZBQJX5UvMEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQJbO B/sFAcH5H6dZGAn7OoyDcpnFZUrBEeUTuvZbDK6WZpcefg9A59qW1EcuaArdbdpG 6ELRgKlN85WLd8S/jV7hwWmJ9qhYmXPSg/2LX/1o6P/W6X5TvlSiiz6Crys5X6qN CQkMR4vGCphezlF1FuVXLP5edws8Y1UTj17XcnI9k6iHJp+Nyio90k9octzyCjyf RRfmXo8b69kHUm64zkH3tNvDFiTC+2wLHcsa0LW+YeEeqIy4n7XhymbgsqoTSiFX X2QtzfGA087aZV3gRbIZVwpjmzH7K8d0M0lkqaKvIIOdhig/wjzSXwSA39NGgl0W L8Ekaa5NBtX06NZUSXstDo9L =7UE5 -----END PGP SIGNATURE----- --ge6QqaDnVmJ0IGWciWkwUXI5VuhDRcqbn--