From: "Volker Rümelin" <vr_qemu@t-online.de>
To: marcandre.lureau@redhat.com, Gerd Hoffmann <kraxel@redhat.com>
Cc: dbassey@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 05/12] audio/pw: needless check for NULL
Date: Sun, 7 May 2023 17:01:30 +0200 [thread overview]
Message-ID: <3f7e1b2a-e409-9a05-ae4d-a6df8c87ab6f@t-online.de> (raw)
In-Reply-To: <20230506163735.3481387-6-marcandre.lureau@redhat.com>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> g_clear_pointer() already checks for NULL.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> audio/pwaudio.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Volker Rümelin <vr_qemu@t-online.de>
> diff --git a/audio/pwaudio.c b/audio/pwaudio.c
> index 51cfc0b052..6ca4ef4f62 100644
> --- a/audio/pwaudio.c
> +++ b/audio/pwaudio.c
> @@ -834,12 +834,8 @@ fail:
> if (pw->thread_loop) {
> pw_thread_loop_stop(pw->thread_loop);
> }
> - if (pw->context) {
> - g_clear_pointer(&pw->context, pw_context_destroy);
> - }
> - if (pw->thread_loop) {
> - g_clear_pointer(&pw->thread_loop, pw_thread_loop_destroy);
> - }
> + g_clear_pointer(&pw->context, pw_context_destroy);
> + g_clear_pointer(&pw->thread_loop, pw_thread_loop_destroy);
> return NULL;
> }
>
next prev parent reply other threads:[~2023-05-07 15:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 16:37 [PATCH 00/12] audio: pipewire backend improvements marcandre.lureau
2023-05-06 16:37 ` [PATCH 01/12] libvirt-ci: update submodule to cover pipewire marcandre.lureau
2023-05-06 16:37 ` [PATCH 02/12] tests/lcitool: add pipewire marcandre.lureau
2023-05-10 7:35 ` Philippe Mathieu-Daudé
2023-05-06 16:37 ` [PATCH 03/12] audio/pw: Pipewire->PipeWire case fix for user-visible text marcandre.lureau
2023-05-07 14:56 ` Volker Rümelin
2023-05-10 7:36 ` Philippe Mathieu-Daudé
2023-05-06 16:37 ` [PATCH 04/12] audio/pw: drop needless case statement marcandre.lureau
2023-05-07 14:58 ` Volker Rümelin
2023-05-06 16:37 ` [PATCH 05/12] audio/pw: needless check for NULL marcandre.lureau
2023-05-07 15:01 ` Volker Rümelin [this message]
2023-05-06 16:37 ` [PATCH 06/12] audio/pw: trace during init before calling pipewire API marcandre.lureau
2023-05-07 15:03 ` Volker Rümelin
2023-05-10 7:37 ` Philippe Mathieu-Daudé
2023-05-06 16:37 ` [PATCH 07/12] audio/pw: add more details on error marcandre.lureau
2023-05-07 15:31 ` Volker Rümelin
2023-05-06 16:37 ` [PATCH 08/12] audio/pw: factorize some common code marcandre.lureau
2023-05-07 15:07 ` Volker Rümelin
2023-05-06 16:37 ` [PATCH 09/12] audio/pw: add more error reporting marcandre.lureau
2023-05-07 15:32 ` Volker Rümelin
2023-05-06 16:37 ` [PATCH 10/12] audio/pw: simplify error reporting in stream creation marcandre.lureau
2023-05-07 15:33 ` Volker Rümelin
2023-05-06 16:37 ` [PATCH 11/12] audio/pw: remove wrong comment marcandre.lureau
2023-05-07 15:11 ` Volker Rümelin
2023-05-06 16:37 ` [PATCH 12/12] audio/pw: improve channel position code marcandre.lureau
2023-05-07 15:13 ` Volker Rümelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f7e1b2a-e409-9a05-ae4d-a6df8c87ab6f@t-online.de \
--to=vr_qemu@t-online.de \
--cc=dbassey@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).