From: "Sebastian Färber" <sfaerber82@gmail.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, jdurgin@redhat.com, jcody@redhat.com,
kwolf@redhat.com, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH] block/rbd: add .bdrv_reopen_prepare() stub
Date: Fri, 13 May 2016 10:29:29 +0200 [thread overview]
Message-ID: <3f8edd94-280c-8aa7-0f07-ab674ee4667b@gmail.com> (raw)
Add support for reopen() by adding the .bdrv_reopen_prepare() stub
Signed-off-by: Sebastian Färber <sfaerber82@gmail.com>
Tested-by: Sebastian Färber <sfaerber82@gmail.com>
---
block/rbd.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/block/rbd.c b/block/rbd.c
index 5bc5b32..5f121b5 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -577,6 +577,14 @@ failed_opts:
return r;
}
+/* Note that this will not re-establish a connection with the Ceph cluster
+ - it is effectively a NOP. */
+static int qemu_rbd_reopen_prepare(BDRVReopenState *state,
+ BlockReopenQueue *queue, Error **errp)
+{
+ return 0;
+}
+
static void qemu_rbd_close(BlockDriverState *bs)
{
BDRVRBDState *s = bs->opaque;
@@ -976,6 +984,7 @@ static BlockDriver bdrv_rbd = {
.instance_size = sizeof(BDRVRBDState),
.bdrv_needs_filename = true,
.bdrv_file_open = qemu_rbd_open,
+ .bdrv_reopen_prepare = qemu_rbd_reopen_prepare,
.bdrv_close = qemu_rbd_close,
.bdrv_create = qemu_rbd_create,
.bdrv_has_zero_init = bdrv_has_zero_init_1,
--
1.8.3.1
next reply other threads:[~2016-05-13 8:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 8:29 Sebastian Färber [this message]
2016-05-13 8:45 ` [Qemu-devel] [PATCH] block/rbd: add .bdrv_reopen_prepare() stub Kevin Wolf
2016-05-17 10:03 ` Sebastian Färber
2016-05-17 14:00 ` Jason Dillaman
2016-05-17 18:48 ` Josh Durgin
2016-05-18 7:36 ` Sebastian Färber
2016-05-18 8:19 ` Kevin Wolf
2016-05-18 15:54 ` Jason Dillaman
2016-05-18 5:31 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f8edd94-280c-8aa7-0f07-ab674ee4667b@gmail.com \
--to=sfaerber82@gmail.com \
--cc=jcody@redhat.com \
--cc=jdurgin@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).