qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Daniele Buono" <dbuono@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] meson: Stop if cfi is enabled with system slirp
Date: Mon, 8 Mar 2021 12:27:18 +0100	[thread overview]
Message-ID: <3f962547-d3ab-3fb6-0b05-f760963d42bb@redhat.com> (raw)
In-Reply-To: <YEYISUuI49rphmDe@redhat.com>

On 08/03/21 12:19, Daniel P. Berrangé wrote:
> My concern is that libslirp is just showing us one known example of
> the problem. QEMU links to many more external libraries, which might
> exhibit similar issues.

We know exactly the issue: QEMU uses a pointer to a library function as 
a function pointer that is called *from QEMU* and not from another library.

More issues like this (or other CFI issues such as the GLib casted event 
handlers) could arise if some but not all the dependencies are linked 
with CFI.  But that should be handled at the distro level; if none of 
the dependencies use CFI, CFI incompatibility issues are fairly limited.

Paolo

> If we need to rebuild all the dependancies
> with CFI too, to be confident that the combined work will operate
> correctly, then this is quite a significant implication. Overall I
> think this is going to be a problem for the changes of distros adopting
> the use of CFI, especially if they're not using CLang as their toolchain.



  reply	other threads:[~2021-03-08 11:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04  2:59 [PATCH] meson: Stop if cfi is enabled with system slirp Daniele Buono
2021-03-04 10:37 ` Daniel P. Berrangé
2021-03-04 10:56   ` Paolo Bonzini
2021-03-05 16:52     ` Daniele Buono
2021-03-05 17:18       ` Paolo Bonzini
2021-03-08 15:05         ` Daniele Buono
2021-03-05 16:53   ` Daniele Buono
2021-03-08 11:19     ` Daniel P. Berrangé
2021-03-08 11:27       ` Paolo Bonzini [this message]
2021-03-08 14:58       ` Daniele Buono

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f962547-d3ab-3fb6-0b05-f760963d42bb@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dbuono@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).