Re: [Qemu-devel] [PATCH v5 2/2] mach-virt: Provide sample configuration files

[Laszlo Ersek <lersek@redhat.com>]

Thanks for the CC!

On 02/08/17 18:35, Andrea Bolognani wrote:

> +# Firmware configuration
> +# =========================================================
> +#
> +# There are two parts to the firmware: a read-only image
> +# containing the executable code, which is shared between
> +# guests, and a read/write variable store that is used by

Apparently omitted:

  one specific virtual machine, exclusively,

Also, I would recommend replacing "used" with "owned".

> +# to record information such as the boot device. An empty

s/boot device/UEFI boot order/

> +# variable store can be created by simply copying a
> +# template provided as part of AAVMF.

How about:

  For any new guest, its permanent, private variable store should
  initially be copied from the template file provided as part of the
  ArmVirtQemu firmware platform (which is occasionally distributed
  under the AAVMF package).

> +#
> +# Depending on the distribution you're using on the host,

I recommend "OS distribution", "Linux distribution", or "GNU/Linux
distribution", as you prefer.

> +# paths to the firmware itself and variable store template

s/firmware/firmware binary/

> +# will be different. Some examples:
> +#
> +# Fedora:
> +#   /usr/share/edk2/aarch64/QEMU_EFI.fd
> +#   /usr/share/edk2/aarch64/QEMU_VARS.fd

Please annotate each as firmware binary & variable store template.

Also, I can't verify the exact pathnames for Fedora.

> +# RHEL:
> +#   /usr/share/AAVMF/AAVMF_CODE.fd
> +#   /usr/share/AAVMF/AAVMF_VARS.fd

Looks legit. (Might want to call "RHEL" "RHELSA" though, in this context
-- no clue. Ask Drew :))

> +
> +[drive "aavmf-code"]

Heh, I never specify "id" for these "-drive"s, but I definitely
appreciate the attention to detail. Let's call it "uefi-binary" though.

> +  file = "/usr/share/edk2/aarch64/QEMU_EFI.fd"  # CHANGE ME

Please replace the comment with

  CHANGE ME ACCORDING TO HOST LINUX DISTRO

or some such

> +  format = "raw"
> +  if = "pflash"
> +  unit = "0"
> +  readonly = "on"
> +
> +[drive "aavmf-vars"]

Let's call this "uefi-varstore".

> +  file = "guest_VARS.fd"                        # CHANGE ME

Many bonus points for providing a file name example that is *different*
from (QEMU|AAVMF)_VARS.fd. It should (and thankfully, does) reflect that
it's already a copy.

Please expand the comment:

  CHANGE ME TO THE NAME OF THE FILE THAT YOU CREATED AS A COPY of THE
  VARSTORE TEMPLATE

> +  format = "raw"
> +  if = "pflash"
> +  unit = "1"

Yes!

I apologize for being too detailed / pedantic about this.

Thanks!
Laszlo