From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0199EC433EF for ; Mon, 28 Feb 2022 18:25:37 +0000 (UTC) Received: from localhost ([::1]:58478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOkiH-0001BK-1q for qemu-devel@archiver.kernel.org; Mon, 28 Feb 2022 13:25:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOkZg-00023D-3c for qemu-devel@nongnu.org; Mon, 28 Feb 2022 13:16:44 -0500 Received: from [2607:f8b0:4864:20::42d] (port=46797 helo=mail-pf1-x42d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOkZe-0007Nx-IM for qemu-devel@nongnu.org; Mon, 28 Feb 2022 13:16:43 -0500 Received: by mail-pf1-x42d.google.com with SMTP id s11so1378236pfu.13 for ; Mon, 28 Feb 2022 10:16:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=lHb8c6LRbXXl25tHeKYdiH5QYvEN0XowB0OR5dnP3eQ=; b=YGMK3lvDQYwbASKX7k7PK2/Han+H5JaaJWb+td+mIOhlfeiLcUj/vbIf1O6qbjJiQo SU0MiPLOqBatfoBoLm6em5+zToF3uIdFKm+MRDWiNFMqI/MC7pWlixGscRWyEYADnv2L IUzZdfT3xuqx+vFcEMM9Gxoa1X2ZMeIQdruSIZG1m7IOa92YWxDGS5MV/scuRRKSFHos 0XxNsSO+jt873uozZFHLIltFiLE3sNNWcVQ3eKepZShkGpM7ok+WQeQ4TI1K6icYfPji 2gkNBINY7gImn5rDyO9YzFl9zlg8wE7IUsREBFjsuAFtKjxvY+ZCxkAepYu1SjP6zxil vR7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=lHb8c6LRbXXl25tHeKYdiH5QYvEN0XowB0OR5dnP3eQ=; b=VoUP2YoIK80+tOgL2dPWhhI3KeZ/vu+iOfyHuTwu4zbL+uNT0O0T+kfsBumRqSzj+0 OcIxI+bzIPpTxsu7Jb1qyQ0NR4WoeIzatDsl0aefvM4PcJP9jC90Wbj4RClwf3uGIQAU O9w/jTiCQQAwSdc+1GG4JKMbptS8Md+lwQTXMdpgIErRSeWy70zJPUMNDVlmzpnwK+67 HqJtcP1tUEv67XPzyWtoY9RPy2X7U/pPT+odrF/NjQxqlp5B2QZEtFlL2Dq9YqDw9hDx rSydnnhd6ngSB9FA/zjJGmNV6Ku7agDeGtnkccINctm7rRL2BefNi7uB8gjV2IYaf6yv OZLA== X-Gm-Message-State: AOAM531yjEJehqXyUVpBRHMaJ5w0LyVwhu0o2MsPwq+zMTzFsfez9lLd +TD4tIjHTrnm07DEXNzx8B2Hrg== X-Google-Smtp-Source: ABdhPJzF5eBgAUaYT2s9lu7b8ZbXL0sL6ES5zRIDNNZxAkgzV9ci/Rxi86mZyBna8uhZHkZIJKLMAA== X-Received: by 2002:a63:4425:0:b0:378:8512:559 with SMTP id r37-20020a634425000000b0037885120559mr7326113pga.464.1646072201211; Mon, 28 Feb 2022 10:16:41 -0800 (PST) Received: from ?IPV6:2603:800c:1201:c600:483f:d486:138f:7868? (2603-800c-1201-c600-483f-d486-138f-7868.res6.spectrum.com. [2603:800c:1201:c600:483f:d486:138f:7868]) by smtp.gmail.com with ESMTPSA id t1-20020a634441000000b00372cb183243sm10983999pgk.1.2022.02.28.10.16.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Feb 2022 10:16:40 -0800 (PST) Message-ID: <3fa7cc33-995b-a6cc-0e95-ad70c2f9ec4e@linaro.org> Date: Mon, 28 Feb 2022 08:16:37 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v6 02/14] target/riscv: rvk: add support for zbkb extension Content-Language: en-US To: Weiwei Li , palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, qemu-riscv@nongnu.org, qemu-devel@nongnu.org References: <20220227142553.25815-1-liweiwei@iscas.ac.cn> <20220227142553.25815-3-liweiwei@iscas.ac.cn> <68883535-a085-169a-044f-04349ad4cc9f@iscas.ac.cn> From: Richard Henderson In-Reply-To: <68883535-a085-169a-044f-04349ad4cc9f@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::42d (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42d.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangjunqiang@iscas.ac.cn, lazyparser@gmail.com, lustrew@foxmail.com, luruibo2000@163.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/27/22 17:02, Weiwei Li wrote: > Thanks for your comments. > > 在 2022/2/28 上午2:47, Richard Henderson 写道: >> On 2/27/22 04:25, Weiwei Li wrote: >>> +static void gen_packh(TCGv ret, TCGv src1, TCGv src2) >>> +{ >>> +    TCGv t = tcg_temp_new(); >>> + >>> +    tcg_gen_ext8u_tl(t, src2); >>> +    tcg_gen_deposit_tl(ret, src1, t, 8, TARGET_LONG_BITS - 8); >>> +    tcg_temp_free(t); >>> +} >>> + >>> +static void gen_packw(TCGv ret, TCGv src1, TCGv src2) >>> +{ >>> +    TCGv t = tcg_temp_new(); >>> + >>> +    tcg_gen_ext16s_tl(t, src2); >>> +    tcg_gen_deposit_tl(ret, src1, t, 16, 48); >>> +    tcg_temp_free(t); >>> +} >> >> Missing TARGET_LONG_BITS here; would break on RV32. > packw is RV64-only instruction. Is it necessary to use TARGET_LONG_BITS here? Ah, I see. So it's not buggy, as-is, but it certainly looks odd next to the previous, and it wouldn't be buggy to use TARGET_LONG_BITS either. This points out that it would be a good idea to keep these generator functions next to the trans function that uses them, for context. r~