From: Richard Henderson <richard.henderson@linaro.org>
To: YunQiang Su <syq@debian.org>, qemu-devel@nongnu.org
Cc: macro@orcam.me.uk, philmd@linaro.org
Subject: Re: [PATCH] mips: pass code of conditional trap
Date: Thu, 20 Jun 2024 21:21:26 -0700 [thread overview]
Message-ID: <3faf6561-804f-4d1c-8204-f4bb9f7a3b94@linaro.org> (raw)
In-Reply-To: <20240620234633.74447-1-syq@debian.org>
On 6/20/24 16:46, YunQiang Su wrote:
> @@ -4553,7 +4559,7 @@ static void gen_trap(DisasContext *ctx, uint32_t opc,
> if (ctx->hflags != ctx->saved_hflags) {
> tcg_gen_movi_i32(hflags, ctx->hflags);
> }
> - generate_exception(ctx, EXCP_TRAP);
> + generate_exception_with_code(ctx, EXCP_TRAP, code);
> gen_set_label(l1);
> }
> }
There are two instances within gen_trap, one of which *does* store into error_code, but
that gets overwritten by do_raise_exception_err.
Search for EXCP_TRAP.
r~
next prev parent reply other threads:[~2024-06-21 4:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 23:46 [PATCH] mips: pass code of conditional trap YunQiang Su
2024-06-21 0:41 ` Maciej W. Rozycki
2024-06-21 0:51 ` YunQiang Su
2024-06-21 12:02 ` Maciej W. Rozycki
2025-09-27 5:33 ` YunQiang Su
2025-10-01 11:18 ` Maciej W. Rozycki
2024-06-21 4:21 ` Richard Henderson [this message]
2024-06-21 4:37 ` YunQiang Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3faf6561-804f-4d1c-8204-f4bb9f7a3b94@linaro.org \
--to=richard.henderson@linaro.org \
--cc=macro@orcam.me.uk \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=syq@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).