qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Jason Wang <jasowang@redhat.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.12 2/2] net: Remove the deprecated -tftp, -bootp, -redir and -smb options
Date: Thu, 14 Dec 2017 13:28:47 +0100	[thread overview]
Message-ID: <3fb76985-d02d-262f-491c-384680a13f3b@redhat.com> (raw)
In-Reply-To: <CAFEAcA9gz0cNkPvZhkLYfYQ+ST01POwuptfXkKixSu_x=s9C+g@mail.gmail.com>

 Hi Peter,

On 11.12.2017 23:04, Peter Maydell wrote:
> On 7 December 2017 at 18:02, Thomas Huth <thuth@redhat.com> wrote:
>> These options likely do not work as expected as soon as the user
>> tries to use more than one network interface at once. The parameters
>> have been marked as deprecated since QEMU v2.6, so users had plenty
>> of time to move their scripts to the new syntax. Time to remove the
>> old parameters now.
> 
> The deprecation message says:
>                error_report("The -redir option is deprecated. "
>                             "Please use '-netdev user,hostfwd=...' instead.");
> 
> How does this work for systems which have embedded ethernet
> devices and can't use -netdev ?

Of course it should work the same way as you currently can configure all
embedded ethernet devices:

 -net nic -net user,hostfwd=...

By the way, I think our documentation is really lacking some proper
description how to deal with on-board devices ...

> This is one reason I haven't bothered to update my scripts yet

-redir is likely not doing what you expect as soon as you are using two
or more (embedded or non-embedded) NICs on a machine, so you really
should not use that option anymore.

> The message also doesn't point out that if you were previously
> using -net + -redir you need to switch to -device + -netdev,
> since -net + -netdev doesn't work AFAIK.

I haven't tried, but I think you can also use:

 -netdev user,id=u1,hostfwd=... -net nic,netdev=u1

Or did you run into problems here?

Anyway, looks like we really have to improve our documentation about
"-net nic" ... yet another item for my TODO list (unless somebody else
wants to have a try)...

 Thomas

  reply	other threads:[~2017-12-14 12:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 18:02 [Qemu-devel] [PATCH for-2.12 0/2] Remove deprecated net parameters Thomas Huth
2017-12-07 18:02 ` [Qemu-devel] [PATCH for-2.12 1/2] net: Remove the legacy "-net channel" parameter Thomas Huth
2017-12-11 21:53   ` Samuel Thibault
2017-12-07 18:02 ` [Qemu-devel] [PATCH for-2.12 2/2] net: Remove the deprecated -tftp, -bootp, -redir and -smb options Thomas Huth
2017-12-11 21:53   ` Samuel Thibault
2017-12-11 22:04   ` Peter Maydell
2017-12-14 12:28     ` Thomas Huth [this message]
2017-12-14 13:16       ` Peter Maydell
2017-12-14 15:38         ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fb76985-d02d-262f-491c-384680a13f3b@redhat.com \
    --to=thuth@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).