From: Richard Henderson <richard.henderson@linaro.org>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Stefan Hajnoczi <stefanha@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 5/7] trace: Add event "guest_bbl_after"
Date: Wed, 13 Sep 2017 10:34:05 -0700 [thread overview]
Message-ID: <3fb9d3ac-db86-2ff7-d6e1-988982d1eb18@linaro.org> (raw)
In-Reply-To: <150506107741.19604.8328467942268087647.stgit@frigg.lan>
On 09/10/2017 09:31 AM, Lluís Vilanova wrote:
> +void translator__gen_goto_tb(TCGContext *ctx)
> +{
> + if (ctx->disas.in_guest_code &&
> + (TRACE_GUEST_BBL_AFTER_ENABLED)) {
> + if (ctx->disas.inline_label == NULL) {
> + ctx->disas.inline_label = gen_new_inline_label();
> + }
> + gen_set_inline_point(ctx->disas.inline_label);
> + /* disable next exit_tb */
> + ctx->disas.seen_goto_tb = true;
> + }
> +}
> +
> +void translator__gen_exit_tb(TCGContext *ctx)
> +{
> + if (ctx->disas.in_guest_code && !ctx->disas.seen_goto_tb &&
> + (TRACE_GUEST_BBL_AFTER_ENABLED)) {
> + if (ctx->disas.inline_label == NULL) {
> + ctx->disas.inline_label = gen_new_inline_label();
> + }
> + gen_set_inline_point(ctx->disas.inline_label);
> + /* enable next exit_tb */
> + ctx->disas.seen_goto_tb = false;
> + }
> +}
I don't understand why you wouldn't just modify tcg_gen_goto_tb and
tcg_gen_exit_tb instead.
r~
next prev parent reply other threads:[~2017-09-13 18:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 16:11 [Qemu-devel] [PATCH 0/7] trace: Add guest code events Lluís Vilanova
2017-09-10 16:15 ` [Qemu-devel] [PATCH 1/7] trace: Add event "guest_bbl_before" Lluís Vilanova
2017-09-13 16:59 ` Richard Henderson
2017-09-14 14:21 ` Lluís Vilanova
2017-09-10 16:19 ` [Qemu-devel] [PATCH 2/7] trace: Add event "guest_inst_before" Lluís Vilanova
2017-09-13 17:02 ` Richard Henderson
2017-09-14 14:40 ` Lluís Vilanova
2017-09-10 16:23 ` [Qemu-devel] [PATCH 3/7] trace: Add event "guest_inst_info_before" Lluís Vilanova
2017-09-13 17:07 ` Richard Henderson
2017-09-14 14:59 ` Lluís Vilanova
2017-09-14 16:12 ` Richard Henderson
2017-09-10 16:27 ` [Qemu-devel] [PATCH 4/7] tcg: Add support for "inlining" regions of code Lluís Vilanova
2017-09-13 17:09 ` Richard Henderson
2017-09-14 15:20 ` Lluís Vilanova
2017-09-14 16:15 ` Richard Henderson
2017-09-15 12:55 ` Lluís Vilanova
2017-09-26 16:31 ` Lluís Vilanova
2017-09-26 16:52 ` Richard Henderson
2017-09-10 16:31 ` [Qemu-devel] [PATCH 5/7] trace: Add event "guest_bbl_after" Lluís Vilanova
2017-09-13 17:34 ` Richard Henderson [this message]
2017-09-14 15:20 ` Lluís Vilanova
2017-09-14 16:16 ` Richard Henderson
2017-09-10 16:35 ` [Qemu-devel] [PATCH 6/7] trace: Add event "guest_inst_after" Lluís Vilanova
2017-09-13 18:01 ` Richard Henderson
2017-09-14 16:23 ` Lluís Vilanova
2017-09-10 16:39 ` [Qemu-devel] [PATCH 7/7] trace: Add event "guest_inst_info_after" Lluís Vilanova
2017-09-13 18:03 ` Richard Henderson
2017-09-10 16:45 ` [Qemu-devel] [PATCH 0/7] trace: Add guest code events no-reply
2017-09-13 14:36 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fb9d3ac-db86-2ff7-d6e1-988982d1eb18@linaro.org \
--to=richard.henderson@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).