From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caz99-0001dv-8z for qemu-devel@nongnu.org; Tue, 07 Feb 2017 01:21:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caz96-0006OC-70 for qemu-devel@nongnu.org; Tue, 07 Feb 2017 01:20:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60794) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1caz96-0006O1-0t for qemu-devel@nongnu.org; Tue, 07 Feb 2017 01:20:56 -0500 References: <1486110164-13797-1-git-send-email-peterx@redhat.com> <1486110164-13797-8-git-send-email-peterx@redhat.com> <20170207060859.GU5151@pxdev.xzpeter.org> From: Jason Wang Message-ID: <3fbb12d7-1f39-6d4e-84f8-99f724145ca2@redhat.com> Date: Tue, 7 Feb 2017 14:20:49 +0800 MIME-Version: 1.0 In-Reply-To: <20170207060859.GU5151@pxdev.xzpeter.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 07/18] intel_iommu: fix trace for inv desc handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: tianyu.lan@intel.com, kevin.tian@intel.com, mst@redhat.com, jan.kiszka@siemens.com, bd.aviv@gmail.com, qemu-devel@nongnu.org, alex.williamson@redhat.com, David Gibson On 2017=E5=B9=B402=E6=9C=8807=E6=97=A5 14:08, Peter Xu wrote: > On Tue, Feb 07, 2017 at 01:38:30PM +0800, Jason Wang wrote: >> >> On 2017=E5=B9=B402=E6=9C=8803=E6=97=A5 16:22, Peter Xu wrote: >>> VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not >>> good, and we should end the day when we need to recompile the code >>> before getting useful debugging information for vt-d. Time to switch = to >>> the trace system. >> Looks like we end up with using debug macros and tracepoints at the sa= me >> time (even with patch 8), this will cause even more troubles. > I was converting debug macros into traces gradually rather than in a > single big patch. Those ones that were converted are possibly useful > for debugging of current series. I can do the rest of convertion in > another standalone patch after this series. That's fine. > >> >>> This is the first patch to do it. >>> >>> Generally, the rule of mine is: >>> >>> - for the old GENERAL typed message, I use trace_vtd_err*() in genera= l. >>> >>> - for the non-GENERAL typed messages, convert into specified trace_*(= ). >>> >>> - for useless DPRINTFs, I removed them. >>> >>> Signed-off-by: Peter Xu >>> --- >> The title is a little bit confusing, this in fact convert from debug m= acros >> to tracepoints. > I'll find a better subject. Thanks, > > -- peterx > Thanks Reviewed-by: Jason Wang