From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Olaf Hering <olaf@aepfle.de>, Laszlo Ersek <lersek@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: roms/efirom, tests/uefi-test-tools: update edk2's own submodules first
Date: Tue, 20 Oct 2020 11:29:01 +0200 [thread overview]
Message-ID: <3fc07eb7-f99a-516b-9bb9-e48049547928@redhat.com> (raw)
In-Reply-To: <20201020091605.GA2301@aepfle.de>
Hi Olaf,
On 10/20/20 11:16 AM, Olaf Hering wrote:
> This is about qemu.git#ec87b5daca761039bbcf781eedbe4987f790836f
>
> On Mon, Sep 07, Laszlo Ersek wrote:
>
>> In edk2 commit 06033f5abad3 ("BaseTools: Make brotli a submodule",
>> 2020-04-16), part of edk2-stable202005, the Brotli compressor /
>> decompressor source code that edk2 had flattened into BaseTools was
>> replaced with a git submodule.
>>
>> This means we have to initialize edk2's own submodules before building
>> BaseTools not just in "roms/Makefile.edk2", but in "roms/Makefile" (for
>> the sake of the "efirom" target) and "tests/uefi-test-tools/Makefile" as
>> well.
>
>> +++ b/roms/Makefile
>> edk2-basetools:
>> + cd edk2/BaseTools && git submodule update --init --force
>> build-edk2-tools:
>> + cd $(edk2_dir)/BaseTools && git submodule update --init --force
>
>
> This change can not possibly be correct.
>
> With current qemu.git#master one is forced to have network access to
> build the roms. This fails with exported (and complete) sources in an
> offline environment.
The EDK2 roms are only used for testing, we certainly don't want them
to be used by distributions. I suppose the question is "why is this
rule called if tests are not built?".
> Please revert this patch.
>
>
> Olaf
>
next prev parent reply other threads:[~2020-10-20 9:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 9:16 roms/efirom, tests/uefi-test-tools: update edk2's own submodules first Olaf Hering
2020-10-20 9:29 ` Philippe Mathieu-Daudé [this message]
2020-10-20 9:35 ` Olaf Hering
2020-10-20 9:38 ` Philippe Mathieu-Daudé
2020-10-20 9:44 ` Daniel P. Berrangé
2020-10-20 9:54 ` Philippe Mathieu-Daudé
2020-10-21 12:05 ` Laszlo Ersek
2020-10-21 12:30 ` Olaf Hering
2020-10-21 13:28 ` Laszlo Ersek
2020-10-21 13:46 ` Daniel P. Berrangé
2020-10-21 17:27 ` Laszlo Ersek
2020-10-20 12:52 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fc07eb7-f99a-516b-9bb9-e48049547928@redhat.com \
--to=philmd@redhat.com \
--cc=lersek@redhat.com \
--cc=olaf@aepfle.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).