qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, berrange@redhat.com,
	qemu-block@nongnu.org, mreitz@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 for-2.10 0/4] improved --version/--help tweaks
Date: Mon, 7 Aug 2017 20:08:29 -0400	[thread overview]
Message-ID: <3fdaf7c5-591e-4702-126d-b6013a12a690@redhat.com> (raw)
In-Reply-To: <20170803163353.19558-1-eblake@redhat.com>



On 08/03/2017 12:33 PM, Eric Blake wrote:
> Not sure if this should go through Kevin's block tree, Paolo's
> miscellaneous patches, or if I should just do a pull request
> myself (since patch 4 includes a change to qemu-nbd)
> 
> since v2: add R-b on 2-4; also sort 'qemu-img --help' create text
> 
> 001/4:[0012] [FC] 'qemu-img: Sort sub-command names in --help'
> 002/4:[----] [--] 'qemu-io: Give more --version information'
> 003/4:[----] [--] 'qga: Give more --version information'
> 004/4:[----] [--] 'maint: Include bug-reporting info in --help output'
> 
> Eric Blake (4):
>   qemu-img: Sort sub-command names in --help
>   qemu-io: Give more --version information
>   qga: Give more --version information
>   maint: Include bug-reporting info in --help output
> 
>  include/qemu-common.h |  5 +++++
>  vl.c                  |  4 +++-
>  bsd-user/main.c       |  2 ++
>  linux-user/main.c     |  4 +++-
>  qemu-img.c            |  2 +-
>  qemu-io.c             |  9 ++++++---
>  qemu-nbd.c            |  2 +-
>  qga/main.c            |  8 +++++---
>  qemu-img-cmds.hx      | 21 ++++++++++++---------
>  9 files changed, 38 insertions(+), 19 deletions(-)
> 

Nothing to keep the commands from going out of order again, it looks
like -- can this be added as a comment or otherwise scripted as a
./hey_it_looks_like_you_are_about_to_release_qemu.sh script that makes
sure we've dotted the 'i's and crossed the 't's?

Lastly, Didn't we fix the certificate issue? (I thought Jeff had) -- and
even if not, it's still the correct address to send people to IMO. Let
people report to us if the SSL certificate appears to be broken.

Eh, regardless of shed coloring:

Reviewed-by: John Snow <jsnow@redhat.com>

  parent reply	other threads:[~2017-08-08  0:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03 16:33 [Qemu-devel] [PATCH v3 for-2.10 0/4] improved --version/--help tweaks Eric Blake
2017-08-03 16:33 ` [Qemu-devel] [PATCH v3 1/4] qemu-img: Sort sub-command names in --help Eric Blake
2017-08-03 16:33 ` [Qemu-devel] [PATCH v3 2/4] qemu-io: Give more --version information Eric Blake
2017-08-03 16:33 ` [Qemu-devel] [PATCH v3 3/4] qga: " Eric Blake
2017-08-03 16:33 ` [Qemu-devel] [PATCH v3 4/4] maint: Include bug-reporting info in --help output Eric Blake
2017-08-08  0:08 ` John Snow [this message]
2017-08-08 13:50   ` [Qemu-devel] [Qemu-block] [PATCH v3 for-2.10 0/4] improved --version/--help tweaks Eric Blake
2017-08-08 14:15     ` Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fdaf7c5-591e-4702-126d-b6013a12a690@redhat.com \
    --to=jsnow@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).